Fix error when invalid domain name is submitted (#19474)

Fix #19175

app/models/concerns/domain_normalizable.rb

@@ -11,5 +11,7 @@ module DomainNormalizable
 
   def normalize_domain
     self.domain = TagManager.instance.normalize_domain(domain&.strip)
+  rescue Addressable::URI::InvalidURIError
+    errors.add(:domain, :invalid)
   end
 end

spec/controllers/api/v1/admin/domain_allows_controller_spec.rb

@@ -94,6 +94,7 @@ RSpec.describe Api::V1::Admin::DomainAllowsController, type: :controller do
   describe 'POST #create' do
     let!(:domain_allow) { Fabricate(:domain_allow, domain: 'example.com') }
 
+    context do
       before do
         post :create, params: { domain: 'foo.bar.com' }
       end
@@ -115,4 +116,15 @@ RSpec.describe Api::V1::Admin::DomainAllowsController, type: :controller do
         expect(DomainAllow.find_by(domain: 'foo.bar.com')).to_not be_nil
       end
     end
+
+    context 'with invalid domain name' do
+      before do
+        post :create, params: { domain: 'foo bar' }
+      end
+
+      it 'returns http unprocessable entity' do
+        expect(response).to have_http_status(422)
+      end
+    end
+  end
 end