From b1a48e05b6b24a1ae37b9bcbc6f767c949ff3d79 Mon Sep 17 00:00:00 2001 From: trwnh Date: Tue, 8 Nov 2022 10:28:02 -0600 Subject: [PATCH] Change Report category to "violation" if rule IDs are provided (#20137) * Change Report category to "violation" if rule IDs are provided * Fix LiteralAsCondition * Add parentheses to conditional statement --- app/services/report_service.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/services/report_service.rb b/app/services/report_service.rb index 8c92cf33469..0ce525b0711 100644 --- a/app/services/report_service.rb +++ b/app/services/report_service.rb @@ -8,7 +8,7 @@ class ReportService < BaseService @target_account = target_account @status_ids = options.delete(:status_ids).presence || [] @comment = options.delete(:comment).presence || '' - @category = options.delete(:category).presence || 'other' + @category = options[:rule_ids].present? ? 'violation' : (options.delete(:category).presence || 'other') @rule_ids = options.delete(:rule_ids).presence @options = options