diff --git a/app/javascript/mastodon/components/scrollable_list.js b/app/javascript/mastodon/components/scrollable_list.js
index f8a7f91d2e5..7cdd63910e4 100644
--- a/app/javascript/mastodon/components/scrollable_list.js
+++ b/app/javascript/mastodon/components/scrollable_list.js
@@ -72,7 +72,7 @@ export default class ScrollableList extends PureComponent {
const someItemInserted = React.Children.count(prevProps.children) > 0 &&
React.Children.count(prevProps.children) < React.Children.count(this.props.children) &&
this.getFirstChildKey(prevProps) !== this.getFirstChildKey(this.props);
- if (someItemInserted && this.node.scrollTop > 0 || this.state.mouseOver) {
+ if (someItemInserted && this.node.scrollTop > 0 || (this.state.mouseOver && !prevProps.isLoading)) {
return this.node.scrollHeight - this.node.scrollTop;
} else {
return null;
diff --git a/app/lib/activitypub/activity.rb b/app/lib/activitypub/activity.rb
index 5b97a6208d2..84d4b175206 100644
--- a/app/lib/activitypub/activity.rb
+++ b/app/lib/activitypub/activity.rb
@@ -78,9 +78,11 @@ class ActivityPub::Activity
notify_about_reblog(status) if reblog_of_local_account?(status)
notify_about_mentions(status)
- # Only continue if the status is supposed to have
- # arrived in real-time
- return unless status.within_realtime_window?
+ # Only continue if the status is supposed to have arrived in real-time.
+ # Note that if @options[:override_timestamps] isn't set, the status
+ # may have a lower snowflake id than other existing statuses, potentially
+ # "hiding" it from paginated API calls
+ return unless @options[:override_timestamps] || status.within_realtime_window?
distribute_to_followers(status)
end
diff --git a/app/lib/activitypub/activity/announce.rb b/app/lib/activitypub/activity/announce.rb
index 8840a450cb7..7e146ea8c43 100644
--- a/app/lib/activitypub/activity/announce.rb
+++ b/app/lib/activitypub/activity/announce.rb
@@ -16,6 +16,7 @@ class ActivityPub::Activity::Announce < ActivityPub::Activity
reblog: original_status,
uri: @json['id'],
created_at: @json['published'],
+ override_timestamps: @options[:override_timestamps],
visibility: original_status.visibility
)
diff --git a/app/lib/activitypub/activity/create.rb b/app/lib/activitypub/activity/create.rb
index edee2691ffc..8d17a4ebe2e 100644
--- a/app/lib/activitypub/activity/create.rb
+++ b/app/lib/activitypub/activity/create.rb
@@ -48,6 +48,7 @@ class ActivityPub::Activity::Create < ActivityPub::Activity
language: detected_language,
spoiler_text: @object['summary'] || '',
created_at: @object['published'],
+ override_timestamps: @options[:override_timestamps],
reply: @object['inReplyTo'].present?,
sensitive: @object['sensitive'] || false,
visibility: visibility_from_audience,
diff --git a/app/lib/ostatus/activity/creation.rb b/app/lib/ostatus/activity/creation.rb
index a24a0093c35..1e7f4702994 100644
--- a/app/lib/ostatus/activity/creation.rb
+++ b/app/lib/ostatus/activity/creation.rb
@@ -40,6 +40,7 @@ class OStatus::Activity::Creation < OStatus::Activity::Base
text: content,
spoiler_text: content_warning,
created_at: published,
+ override_timestamps: @options[:override_timestamps],
reply: thread?,
language: content_language,
visibility: visibility_scope,
@@ -61,7 +62,14 @@ class OStatus::Activity::Creation < OStatus::Activity::Base
Rails.logger.debug "Queuing remote status #{status.id} (#{id}) for distribution"
LinkCrawlWorker.perform_async(status.id) unless status.spoiler_text?
- DistributionWorker.perform_async(status.id) if status.within_realtime_window?
+
+ # Only continue if the status is supposed to have arrived in real-time.
+ # Note that if @options[:override_timestamps] isn't set, the status
+ # may have a lower snowflake id than other existing statuses, potentially
+ # "hiding" it from paginated API calls
+ return status unless @options[:override_timestamps] || status.within_realtime_window?
+
+ DistributionWorker.perform_async(status.id)
status
end
diff --git a/app/models/status.rb b/app/models/status.rb
index 44238ca6b7e..0b3a7c0aaaf 100644
--- a/app/models/status.rb
+++ b/app/models/status.rb
@@ -33,6 +33,10 @@ class Status < ApplicationRecord
include Cacheable
include StatusThreadingConcern
+ # If `override_timestamps` is set at creation time, Snowflake ID creation
+ # will be based on current time instead of `created_at`
+ attr_accessor :override_timestamps
+
update_index('statuses#status', :proper) if Chewy.enabled?
enum visibility: [:public, :unlisted, :private, :direct], _suffix: :visibility
diff --git a/app/workers/activitypub/processing_worker.rb b/app/workers/activitypub/processing_worker.rb
index bb9adf64bde..0e2e0edddba 100644
--- a/app/workers/activitypub/processing_worker.rb
+++ b/app/workers/activitypub/processing_worker.rb
@@ -6,6 +6,6 @@ class ActivityPub::ProcessingWorker
sidekiq_options backtrace: true
def perform(account_id, body)
- ActivityPub::ProcessCollectionService.new.call(body, Account.find(account_id))
+ ActivityPub::ProcessCollectionService.new.call(body, Account.find(account_id), override_timestamps: true)
end
end
diff --git a/app/workers/processing_worker.rb b/app/workers/processing_worker.rb
index 5df404bcc9b..978c3aba26f 100644
--- a/app/workers/processing_worker.rb
+++ b/app/workers/processing_worker.rb
@@ -6,6 +6,6 @@ class ProcessingWorker
sidekiq_options backtrace: true
def perform(account_id, body)
- ProcessFeedService.new.call(body, Account.find(account_id))
+ ProcessFeedService.new.call(body, Account.find(account_id), override_timestamps: true)
end
end
diff --git a/config/locales/ja.yml b/config/locales/ja.yml
index 62ca6d40bcf..be9e2da2c28 100644
--- a/config/locales/ja.yml
+++ b/config/locales/ja.yml
@@ -805,7 +805,7 @@ ja:
default: "%Y年%m月%d日 %H:%M"
two_factor_authentication:
code_hint: 確認するには認証アプリで表示されたコードを入力してください
- description_html: "二段階認証を有効にするとログイン時、電話でコードを受け取る必要があります。"
+ description_html: "二段階認証を有効にするとログイン時、認証アプリからコードを入力する必要があります。"
disable: 無効
enable: 有効
enabled: 二段階認証は有効になっています
diff --git a/lib/mastodon/snowflake.rb b/lib/mastodon/snowflake.rb
index 219e323d487..9e5bc7383c1 100644
--- a/lib/mastodon/snowflake.rb
+++ b/lib/mastodon/snowflake.rb
@@ -7,7 +7,7 @@ module Mastodon::Snowflake
def self.around_create(record)
now = Time.now.utc
- if record.created_at.nil? || record.created_at >= now || record.created_at == record.updated_at
+ if record.created_at.nil? || record.created_at >= now || record.created_at == record.updated_at || record.override_timestamps
yield
else
record.id = Mastodon::Snowflake.id_at(record.created_at)