From 514db316f798f3e9b65d1591ff88f7c82289ae38 Mon Sep 17 00:00:00 2001 From: David Yip Date: Tue, 9 Jan 2018 20:12:28 -0600 Subject: [PATCH] The flavour parameter is unused, so omit it (#317) --- app/controllers/settings/flavours_controller.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/controllers/settings/flavours_controller.rb b/app/controllers/settings/flavours_controller.rb index a4bdcdf3e32..a2d2c9deee3 100644 --- a/app/controllers/settings/flavours_controller.rb +++ b/app/controllers/settings/flavours_controller.rb @@ -16,7 +16,7 @@ class Settings::FlavoursController < Settings::BaseController end def update - user_settings.update(user_settings_params(params[:flavour])) + user_settings.update(user_settings_params) redirect_to action: 'show', flavour: params[:flavour] end @@ -26,7 +26,7 @@ class Settings::FlavoursController < Settings::BaseController UserSettingsDecorator.new(current_user) end - def user_settings_params(flavour) + def user_settings_params { setting_flavour: params.require(:flavour), setting_skin: params.dig(:user, :setting_skin) }.with_indifferent_access