ariadne
/
pkgconf
3
6
Fork 4
Code Issues 6 Pull Requests 2 Projects Releases 2 Wiki Activity

Fix uncasted use of isspace()
ci/woodpecker/push/woodpecker Pipeline was successful Details 

isspace() is intended to be used with an unsigned 8-bit input.
Using isspace() with any other type of input is technically
undefined behavior.
master
Taylor R Campbell 2024-05-16 21:28:37 +00:00 committed by Ariadne Conill
parent 2d26db3a98
commit 633433b29b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cli/main.c
View File

@ -369,7 +369,7 @@ apply_modversion(pkgconf_client_t *client, pkgconf_pkg_t *world, void *data, int
if (name_len > strlen(queue_node->package) || if (name_len > strlen(queue_node->package) ||
strncmp(pkg->why, queue_node->package, name_len) || strncmp(pkg->why, queue_node->package, name_len) ||
(queue_node->package[name_len] != 0 && (queue_node->package[name_len] != 0 &&
!isspace(queue_node->package[name_len]) && !isspace((unsigned char)queue_node->package[name_len]) &&
!PKGCONF_IS_OPERATOR_CHAR(queue_node->package[name_len]))) !PKGCONF_IS_OPERATOR_CHAR(queue_node->package[name_len])))
continue; continue;