From a391f9b650b3d7bfb55227fec37edfc53e85b69b Mon Sep 17 00:00:00 2001 From: Dylan Baker Date: Wed, 3 Aug 2022 16:32:35 -0700 Subject: [PATCH] pkg: use goto cleanup idiom --- libpkgconf/pkg.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libpkgconf/pkg.c b/libpkgconf/pkg.c index af68943..3eb67f2 100644 --- a/libpkgconf/pkg.c +++ b/libpkgconf/pkg.c @@ -1470,21 +1470,18 @@ pkgconf_pkg_walk_list(pkgconf_client_t *client, if (pkgdep->serial == client->serial) { pkgdep->hits++; - pkgconf_pkg_unref(client, pkgdep); - continue; + goto next; } if (skip_flags && (depnode->flags & skip_flags) == skip_flags) - { - pkgconf_pkg_unref(client, pkgdep); - continue; - } + goto next; pkgconf_audit_log_dependency(client, pkgdep, depnode); pkgdep->hits++; pkgdep->serial = client->serial; eflags |= pkgconf_pkg_traverse_main(client, pkgdep, func, data, depth - 1, skip_flags); +next: pkgconf_pkg_unref(client, pkgdep); }