ariadne
/
pkgconf
3
6
Fork 4
Code Issues 6 Pull Requests 2 Projects Releases 2 Wiki Activity

pass client and user data to error handler #100

Merged
plicease merged 1 commits from error-handler-data into master 2016-12-13 18:03:59 +00:00
Conversation 2 Commits 1 Files Changed 4
plicease commented 2016-12-13 10:45:47 +00:00 (Migrated from github.com)

Would it be possible to pass in the client object and some user data into the error handler? This will help me route errors to the appropriate client object.

Would it be possible to pass in the client object and some user data into the error handler? This will help me route errors to the appropriate client object.
ariadne requested changes 2016-12-13 17:43:57 +00:00
ariadne left a comment

Looks good, but please make the mentioned changes.

Looks good, but please make the mentioned changes.
libpkgconf/client.c
@ -42,3 +43,3 @@
*/
void
pkgconf_client_init(pkgconf_client_t *client, pkgconf_error_handler_func_t error_handler)
pkgconf_client_init(pkgconf_client_t *client, pkgconf_error_handler_func_t error_handler, void *error_handler_data)
ariadne commented 2016-12-13 17:42:56 +00:00

Please add the new :param: here.

Please add the new `:param:` here.
libpkgconf/client.c
ariadne commented 2016-12-13 17:43:10 +00:00

Likewise. Please add the new :param: here.

Likewise. Please add the new `:param:` here.
libpkgconf/libpkgconf.h
ariadne commented 2016-12-13 17:42:20 +00:00

indentation should be tab, not spaces.

indentation should be tab, not spaces.
plicease commented 2016-12-13 18:01:23 +00:00 (Migrated from github.com)

fixed!

fixed!
ariadne commented 2016-12-13 18:04:06 +00:00

Coooool. Thanks.

Coooool. Thanks.
Sign in to join this conversation.
Reviewers
No reviewers
ariadne
Labels
Clear labels   
bug
   
duplicate
   
enhancement
   
invalid
   
question
   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ariadne/pkgconf#100
There is no content yet.
Delete Branch "error-handler-data"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?