Do not check for Requires.private unless --static requested #126

New Issue

ariadne · 2017-09-01T07:45:35Z

ignatenkobrain commented

2017-09-01 07:45:35 +00:00

(Migrated from github.com)

There was bug in Fedora in libselinux package which has libpcre in Requires.private. so libpcre.pc didn't exist on my system and when I was asking for pkg-config --cflags libpcre it was saying that libpcre.pc doesn't exist.. But pkgconf should not care because I didn't ask for static build.

There was bug in Fedora in libselinux package which has `libpcre` in `Requires.private`. so libpcre.pc didn't exist on my system and when I was asking for `pkg-config --cflags libpcre` it was saying that `libpcre.pc` doesn't exist.. But pkgconf should not care because I didn't ask for static build.

ariadne commented

2017-09-02 00:16:42 +00:00

This is intentional.

In almost all cases, headers belonging to Requires.private are referenced indirectly. So we need to ensure the dependency is satisfied to compile.

The only case where Requires and Requires.private should be differently handled is linking, which pkgconf correctly follows.

This is intentional. In almost all cases, headers belonging to `Requires.private` are referenced indirectly. So we need to ensure the dependency is satisfied to compile. The only case where `Requires` and `Requires.private` should be differently handled is linking, which pkgconf correctly follows.

ignatenkobrain commented

2017-09-02 05:44:31 +00:00

(Migrated from github.com)

@kaniini but there is Cflags.private where people should set their private includedirs..!

@kaniini but there is `Cflags.private` where people should set their private includedirs..!

tonytheodore commented

2017-09-02 13:19:35 +00:00

(Migrated from github.com)

@ignatenkobrain, Cflags.private isn't available in pkg-config.

@ignatenkobrain, `Cflags.private` isn't available in `pkg-config`.

ariadne commented

2017-09-04 08:19:32 +00:00