PKGCONF_PKG_PKGF_SIMPLIFY_ERRORS is not always considered #134

New Issue

2017-09-12T23:02:20Z

karen-arutyunov commented

2017-09-12 23:02:20 +00:00

(Migrated from github.com)

Currently the PKGCONF_PKG_PKGF_SIMPLIFY_ERRORS flag is considered only in a single place of pkgconf_pkg_report_graph_error() function, so just the main error message is reported to the client-supplied error handler.

Shouldn't this flag be considered in other places as well, specifically in the rest of pkgconf_pkg_report_graph_error() and in pkgconf_pkg_walk_conflicts_list() ?

The rationale for this is that the additional error messages usually contain some hints that mention pkg-config-specific environment variables that can be irrelevant for an executable that links libpkgconf library, and being printed confuse its users.

Currently the PKGCONF_PKG_PKGF_SIMPLIFY_ERRORS flag is considered only in a single place of pkgconf_pkg_report_graph_error() function, so just the main error message is reported to the client-supplied error handler. Shouldn't this flag be considered in other places as well, specifically in the rest of pkgconf_pkg_report_graph_error() and in pkgconf_pkg_walk_conflicts_list() ? The rationale for this is that the additional error messages usually contain some hints that mention pkg-config-specific environment variables that can be irrelevant for an executable that links libpkgconf library, and being printed confuse its users.

Sign in to join this conversation.