Removing _GNU_SOURCE macro definition from stdinc.h #135

New Issue

ariadne · 2017-09-13T14:45:52Z

karen-arutyunov commented

2017-09-13 14:45:52 +00:00

(Migrated from github.com)

Could you remove _GNU_SOURCE from stdinc.h, which is implicitly get defined in the library client code when libpkgconf.h is included?

One of the problems is that if this macro is already defined in the client code (for example g++ defines it by default in contrast to gcc), then the "redefined macro" warning is issued.

This macro is only required for the library source code compilation, so can safely be moved to source files that require it.

Could you remove _GNU_SOURCE from stdinc.h, which is implicitly get defined in the library client code when libpkgconf.h is included? One of the problems is that if this macro is already defined in the client code (for example g++ defines it by default in contrast to gcc), then the "redefined macro" warning is issued. This macro is only required for the library source code compilation, so can safely be moved to source files that require it.

ariadne commented

2017-09-13 19:35:58 +00:00

actually, the macro is not required at all, and i have no idea how it got there, so i removed it.

Sign in to join this conversation.