argv buffer overflow? #206

New Issue

2021-01-07T19:34:00Z

jmoguillansky-gpsw commented

2021-01-07 19:34:00 +00:00

(Migrated from github.com)

Hi,
in cli/main.c:

const char *package = argv[pkg_optind];

pkg_optind is initialized to 1 (in getopt_long.c).

What if argc is 1 (i.e. no params were passed, just the executable path)?
This may cause buffer overflow?
Should this be:
const char *package = (argc == 1) ? NULL : argv[pkg_optind];

Hi, in cli/main.c: const char *package = argv[pkg_optind]; pkg_optind is initialized to 1 (in getopt_long.c). What if argc is 1 (i.e. no params were passed, just the executable path)? This may cause buffer overflow? Should this be: const char *package = (argc == 1) ? NULL : argv[pkg_optind];

Sign in to join this conversation.