[RFC] Slightly rework Windows path handling to be more pkg-config compatible #212

New Issue

ariadne · 2021-02-18T09:24:08Z

lazka commented

2021-02-18 09:24:08 +00:00

(Migrated from github.com)

In MSYS2 we've switched from pkg-config to pkgconf some weeks ago for native Windows builds and had to patch some things regarding directory separators to fix some builds and make the meson test suite pass. It's been working nicely since then.

It mainly comes down to this patch: https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-pkgconf/0004-fix-prefix-dirsep.patch (this is against the last release, so for master there are more changes/reverts)

Don't normalize "\" to "/" at the end as it breaks escaping of spaces etc
Assume path values in the .pc file either use "/" (preferred) or "\\" (escaped backslash). This makes Windows less of a special case again.
When inserting the relocation prefix escape it and convert "\" to "/" first, so that in combination with the .pc content we have a valid path value again.

I'd try to clean this up and create a PR if this is something that seems acceptable.

In MSYS2 we've switched from pkg-config to pkgconf some weeks ago for native Windows builds and had to patch some things regarding directory separators to fix some builds and make the meson test suite pass. It's been working nicely since then. It mainly comes down to this patch: https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-pkgconf/0004-fix-prefix-dirsep.patch (this is against the last release, so for master there are more changes/reverts) * Don't normalize "\\" to "/" at the end as it breaks escaping of spaces etc * Assume path values in the .pc file either use "/" (preferred) or "\\\\" (escaped backslash). This makes Windows less of a special case again. * When inserting the relocation prefix escape it and convert "\\" to "/" first, so that in combination with the .pc content we have a valid path value again. I'd try to clean this up and create a PR if this is something that seems acceptable.

ariadne commented

2021-02-19 08:55:25 +00:00

This seems fine to me.