Make SYSTEM_LIBDIR a list #63

New Issue

ariadne · 2014-03-25T21:30:00Z

andrewshadura commented

2014-03-25 21:30:00 +00:00

(Migrated from github.com)

On some systems, libdir may be not a single directory, but a list of multiple directories, as it's the case with Debian multiarch, see Debian bug #742634. Please accept a colon-separated list of directories as an argument to --with-system-libdir=.

On some systems, libdir may be not a single directory, but a list of multiple directories, as it's the case with Debian multiarch, see [Debian bug #742634](http://bugs.debian.org/742634). Please accept a colon-separated list of directories as an argument to `--with-system-libdir=`.

ariadne commented

2014-05-11 23:57:17 +00:00

I believe we already do this, but I will doublecheck.

ariadne commented

2014-06-01 07:34:38 +00:00

Yeah, we already do this, it's even documented in README.md. Please reopen if it's not working.

andrewshadura commented

2014-06-01 07:37:18 +00:00

(Migrated from github.com)

It's not working. Moreover, before opening this bug, I've checked the
source, and the was no such thing there, and I couldn't implement a proper
solution. Please correct me if I'm wrong.

Cheers,
Andrew

It's not working. Moreover, before opening this bug, I've checked the source, and the was no such thing there, and I couldn't implement a proper solution. Please correct me if I'm wrong. ## Cheers, Andrew

andrewshadura commented

2014-06-01 08:02:36 +00:00

(Migrated from github.com)

If I understand correctly, here the code is missing:

static bool
fragment_has_system_dir(pkg_fragment_t *frag)
{
    switch (frag->type)
    {
    case 'L':
        if ((want_flags & PKG_KEEP_SYSTEM_LIBS) == 0 && !strcasecmp(SYSTEM_LIBDIR, frag->data))
            return true;
    case 'I':
        if ((want_flags & PKG_KEEP_SYSTEM_CFLAGS) == 0 && !strcasecmp(SYSTEM_INCLUDEDIR, frag->data))
            return true;
    default:
        break;
    }

    return false;
}

If I understand correctly, here the code is missing: ``` c static bool fragment_has_system_dir(pkg_fragment_t *frag) { switch (frag->type) { case 'L': if ((want_flags & PKG_KEEP_SYSTEM_LIBS) == 0 && !strcasecmp(SYSTEM_LIBDIR, frag->data)) return true; case 'I': if ((want_flags & PKG_KEEP_SYSTEM_CFLAGS) == 0 && !strcasecmp(SYSTEM_INCLUDEDIR, frag->data)) return true; default: break; } return false; } ```

ariadne commented

2014-06-06 09:57:28 +00:00

okay. i will look at it soon.

andrewshadura commented

2014-06-07 20:28:55 +00:00

(Migrated from github.com)

Cool, thanks!

Sign in to join this conversation.