ariadne
/
smol
2
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

history: emit a warning when file cannot be made private [coverity]

master
Benno Schulenberg 2021-09-07 16:44:08 +02:00
parent 0ac2dfd920
commit 64a8f1930e
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/history.c
View File

@ -367,7 +367,8 @@ void save_history(void)
} }
/* Don't allow others to read or write the history file. */ /* Don't allow others to read or write the history file. */
chmod(histname, S_IRUSR | S_IWUSR); if (chmod(histname, S_IRUSR | S_IWUSR) < 0)
jot_error(N_("Cannot limit permissions on %s: %s"), histname, strerror(errno));
if (!write_list(searchtop, histfile) || !write_list(replacetop, histfile) || if (!write_list(searchtop, histfile) || !write_list(replacetop, histfile) ||
!write_list(executetop, histfile)) !write_list(executetop, histfile))
@ -465,7 +466,8 @@ void save_poshistory(void)
} }
/* Don't allow others to read or write the history file. */ /* Don't allow others to read or write the history file. */
chmod(poshistname, S_IRUSR | S_IWUSR); if (chmod(poshistname, S_IRUSR | S_IWUSR) < 0)
jot_error(N_("Cannot limit permissions on %s: %s"), poshistname, strerror(errno));
for (posptr = position_history; posptr != NULL; posptr = posptr->next) { for (posptr = position_history; posptr != NULL; posptr = posptr->next) {
char *path_and_place; char *path_and_place;