From 7ae305fdc0777be9ac0dfad48d8514d23526f0dc Mon Sep 17 00:00:00 2001 From: Benno Schulenberg Date: Sun, 27 Oct 2019 10:40:09 +0100 Subject: [PATCH] tweaks: group the closing of descriptors together, for compactness --- src/text.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/text.c b/src/text.c index 99b89f88..56bc5643 100644 --- a/src/text.c +++ b/src/text.c @@ -2365,12 +2365,11 @@ const char *do_int_speller(const char *tempfile_name) if (dup2(tempfile_fd, STDIN_FILENO) != STDIN_FILENO) exit(7); - close(tempfile_fd); - /* Connect standard output to the write end of the first pipe. */ if (dup2(spell_fd[1], STDOUT_FILENO) != STDOUT_FILENO) exit(8); + close(tempfile_fd); close(spell_fd[0]); close(spell_fd[1]); @@ -2390,12 +2389,11 @@ const char *do_int_speller(const char *tempfile_name) if (dup2(spell_fd[0], STDIN_FILENO) != STDIN_FILENO) exit(7); - close(spell_fd[0]); - /* Connect standard output to the write end of the second pipe. */ if (dup2(sort_fd[1], STDOUT_FILENO) != STDOUT_FILENO) exit(8); + close(spell_fd[0]); close(sort_fd[0]); close(sort_fd[1]); @@ -2413,11 +2411,10 @@ const char *do_int_speller(const char *tempfile_name) if (dup2(sort_fd[0], STDIN_FILENO) != STDIN_FILENO) exit(7); - close(sort_fd[0]); - if (dup2(uniq_fd[1], STDOUT_FILENO) != STDOUT_FILENO) exit(8); + close(sort_fd[0]); close(uniq_fd[0]); close(uniq_fd[1]);