From 8eddf7bc269f5df5c33206f9a60efab3dabef678 Mon Sep 17 00:00:00 2001 From: Benno Schulenberg Date: Fri, 17 Jul 2020 16:52:47 +0200 Subject: [PATCH] tweaks: reshuffle a condition, to avoid a repetition of code --- src/files.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/files.c b/src/files.c index 9cc58c76..813a0eb0 100644 --- a/src/files.c +++ b/src/files.c @@ -1655,16 +1655,11 @@ bool make_backup_of(char *realname) original = fopen(realname, "rb"); - if (original == NULL) { - warn_and_briefly_pause(_("Cannot read original file")); - fclose(backup_file); - goto failure; - } + /* If opening succeeded, copy the existing file to the backup. */ + if (original != NULL) + verdict = copy_file(original, backup_file, FALSE); - /* Copy the existing file to the backup. */ - verdict = copy_file(original, backup_file, FALSE); - - if (verdict < 0) { + if (original == NULL || verdict < 0) { warn_and_briefly_pause(_("Cannot read original file")); fclose(backup_file); goto failure;