ariadne
/
smol
2
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

speller: take into account that statting a file can fail [coverity]

master
Benno Schulenberg 2020-07-05 17:17:09 +02:00
parent ee78f2348b
commit 940a17268b
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/text.c
View File

@ -2094,20 +2094,22 @@ const char *treat(char *tempfile_name, char *theprogram, bool spelling)
size_t pww_save = openfile->placewewant; size_t pww_save = openfile->placewewant;
bool was_at_eol = (openfile->current->data[openfile->current_x] == '\0'); bool was_at_eol = (openfile->current->data[openfile->current_x] == '\0');
struct stat fileinfo; struct stat fileinfo;
long timestamp_sec, timestamp_nsec; long timestamp_sec = 0;
long timestamp_nsec = 0;
static char **arguments = NULL; static char **arguments = NULL;
pid_t thepid; pid_t thepid;
int program_status; int program_status;
bool replaced = FALSE; bool replaced = FALSE;
/* Get the timestamp and the size of the temporary file. */ /* Stat the temporary file. If that succeeds and its size is zero,
stat(tempfile_name, &fileinfo); * there is nothing to do; otherwise, store its time of modification. */
timestamp_sec = (long)fileinfo.st_mtim.tv_sec; if (stat(tempfile_name, &fileinfo) == 0) {
timestamp_nsec = (long)fileinfo.st_mtim.tv_nsec; if (fileinfo.st_size == 0)
return NULL;
/* If the number of bytes to check is zero, get out. */ timestamp_sec = (long)fileinfo.st_mtim.tv_sec;
if (fileinfo.st_size == 0) timestamp_nsec = (long)fileinfo.st_mtim.tv_nsec;
return NULL; }
/* Exit from curses mode to give the program control of the terminal. */ /* Exit from curses mode to give the program control of the terminal. */
endwin(); endwin();
@ -2139,12 +2141,10 @@ const char *treat(char *tempfile_name, char *theprogram, bool spelling)
} else if (WEXITSTATUS(program_status) != 0) } else if (WEXITSTATUS(program_status) != 0)
statusline(ALERT, _("Program '%s' complained"), arguments[0]); statusline(ALERT, _("Program '%s' complained"), arguments[0]);
/* Stat the temporary file again. */
stat(tempfile_name, &fileinfo);
/* When the temporary file wasn't touched, say so and leave. */ /* When the temporary file wasn't touched, say so and leave. */
if ((long)fileinfo.st_mtim.tv_sec == timestamp_sec && if (timestamp_sec > 0 && stat(tempfile_name, &fileinfo) == 0 &&
(long)fileinfo.st_mtim.tv_nsec == timestamp_nsec) { (long)fileinfo.st_mtim.tv_sec == timestamp_sec &&
(long)fileinfo.st_mtim.tv_nsec == timestamp_nsec) {
statusbar(_("Nothing changed")); statusbar(_("Nothing changed"));
return NULL; return NULL;
} }