ariadne
/
smol
2
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

files: remove two superfluous calls for shielding temp files from others 

If there are still systems where mkstemp() creates world-readable
temporary files, then please holler.  On current BSDs and on GNU,
I've verified that mkstemp() creates files with 0600 permissions.
master
Benno Schulenberg 2020-05-26 13:40:11 +02:00
parent f8366cd5c9
commit b48dfde3b2
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/files.c
View File

@ -1398,7 +1398,6 @@ char *safe_tempfile(FILE **stream)
{ {
const char *env_dir = getenv("TMPDIR"); const char *env_dir = getenv("TMPDIR");
char *tempdir = NULL, *tempfile_name = NULL; char *tempdir = NULL, *tempfile_name = NULL;
mode_t was_mask;
int fd; int fd;
/* Get the absolute path for the first directory among $TMPDIR /* Get the absolute path for the first directory among $TMPDIR
@ -1415,12 +1414,8 @@ char *safe_tempfile(FILE **stream)
tempfile_name = charealloc(tempdir, strlen(tempdir) + 12); tempfile_name = charealloc(tempdir, strlen(tempdir) + 12);
strcat(tempfile_name, "nano.XXXXXX"); strcat(tempfile_name, "nano.XXXXXX");
was_mask = umask(S_IRWXG | S_IRWXO);
fd = mkstemp(tempfile_name); fd = mkstemp(tempfile_name);
umask(was_mask);
if (fd == -1) { if (fd == -1) {
free(tempfile_name); free(tempfile_name);
return NULL; return NULL;