56960ce05e
tweaks: reshuffle some stuff, to have related things together
...
Also for compactness, and not to use 'lead_len' for two purposes.
2020-03-10 10:45:46 +01:00
e247be69bf
justify: when the cursor is at the left edge, keep it there
...
Only when the endpoint of the selection is actually IN a leading part,
then it should be advanced to include the whole leading part, so that
the succeeding paragraph will get the proper first-line indentation.
2020-03-10 10:32:21 +01:00
e209686835
justify: give the first line of a marked region its proper indentation
...
When justifying a selection from the middle of a paragraph, the first
line of both that selection and of the new paragraph after it should
get the same indentation as the first line of the original paragraph.
This fulfills https://savannah.gnu.org/bugs/?56308 .
2020-03-10 10:29:49 +01:00
047936c338
tweaks: reshuffle an assignment and a free()
2020-03-09 14:28:57 +01:00
ca0571ea52
tweaks: remove an unneeded indirection
...
The concatenating function does not change the passed linestruct.
The data yes, but not the linestruct itself.
2020-03-09 14:25:41 +01:00
655cf9573f
tweaks: always determine the second lead, to simplify the rewrap call
...
Also rename some variables.
2020-03-09 14:11:47 +01:00
c457f744ef
justify: trim the leading blanks of a marked region at the right moment
...
This fixes https://savannah.gnu.org/bugs/?57977 .
Bug existed since commit 5310a355
2020-03-09 14:05:18 +01:00
8f3ea23ece
tweaks: rename a variable, to not be a substring of a function name
2020-03-09 12:31:10 +01:00
3225c71ecd
justify: when appropriate, move end point of marked region forward
...
So that also the line after the newly made paragraph gets the
leading part that belongs to the start of a new paragraph.
This https://savannah.gnu.org/bugs/?57974 .
Bug existed since version 4.0, since the justifying
of a marked region was introduced.
2020-03-09 12:15:01 +01:00
5310a355ef
tweaks: reshuffle the trimming of leading whitespace, for compactness
2020-03-09 11:43:50 +01:00
d7875cdf4f
tweaks: when appropriate, move starting point of justified region back
...
This makes things simpler, so that I can understand them.
2020-03-09 11:33:16 +01:00
dc05defb8a
tweaks: rename four variables, to be a bit more telling
2020-03-09 11:10:07 +01:00
98c11d0a82
tweaks: reshuffle some code, in preparation for improving it
2020-03-09 11:09:56 +01:00
14f1652842
tweaks: move a function to its proper place in the order of things
2020-03-09 09:44:43 +01:00
d4b97a08cd
tweaks: elide a variable and an unneeded iteration
2020-03-08 16:55:02 +01:00
c934c1d71b
justify: trim prefixed whitespace when justifying a marked region
...
This fixes https://savannah.gnu.org/bugs/?56307 .
Bug existed since version 4.0, when the justifying
of a marked region was introduced.
2020-03-08 16:18:34 +01:00
a16315a65f
tweaks: remove a redundant statement, a spurious reference to 'cutbottom'
...
This assignment should have been removed in commit f5ac8c1e
2020-03-08 15:50:55 +01:00
d6beca5dcf
justify: do not copy too many bytes when trimming leading whitespace
...
This fixes https://savannah.gnu.org/bugs/?57972 .
Bug existed since version 4.0, commit 877a6498
2020-03-08 15:09:40 +01:00
9d7e62be1a
tweaks: rename two variables, to be different or for more contrast
...
Also, invert the logic of the second.
2020-03-08 14:12:45 +01:00
5c008726f0
tweaks: rename two variables, to harmonize with two others
2020-03-08 14:04:29 +01:00
8c506d86af
tweaks: rename two variables, to suit both the marked and unmarked case
2020-03-08 13:57:04 +01:00
db7a49edc6
tweaks: create an undo item earlier, and discard it when needed
...
This avoids having to temporariyly store and then later fill in
the original cursor position.
2020-03-08 13:40:38 +01:00
2428c5cbe6
tweaks: strip a parameter that is equivalent to 'openfile' for both calls
2020-03-08 12:54:47 +01:00
01bc0148c0
tweaks: strip a parameter that is TRUE for both calls
...
The parameter has been redundant since version 4.0, commit d54840c1
2020-03-08 12:48:41 +01:00
a92511ceaf
tweaks: move another function to where it is used
2020-03-06 18:52:42 +01:00
19517fc51e
tweaks: elide a parameter, and rename a variable
2020-03-06 17:06:14 +01:00
71c35d3ca2
tweaks: move a function to where it is used
2020-03-06 17:00:31 +01:00
38af812a82
tweaks: reshuffle the setting of the starting point of a cut
2020-03-06 16:57:22 +01:00
622111613f
tweaks: elide two variables and their two assignments
...
Also reshuffle two declarations, and confine the swapping of
the endpoints of a backward-marked region to a smaller scope.
2020-03-06 12:49:06 +01:00
21ef05058c
tweaks: add a COUPLE_END undo item a bit later, instead of updating it
2020-03-06 12:30:24 +01:00
abcdd6605c
tweaks: reshuffle a condition, for compacter code
2020-03-05 19:37:09 +01:00
f2d89cb3bc
justify: restore a region properly when it was marked backwards
...
This fixes https://savannah.gnu.org/bugs/?57960 .
Bug existed since version 4.8, commit e01651cd
2020-03-05 18:46:37 +01:00
2d05ce37c6
justify: do not crash when the user attempts to justify an empty region
...
This fixes https://savannah.gnu.org/bugs/?57959 .
Bug existed since version 4.0, since the justifying
of a marked region was introduced.
2020-03-05 16:57:16 +01:00
2bc5c1987c
tweaks: factor out a three-line condition into a separate function
...
For clarity.
2020-03-05 16:09:56 +01:00
e39e2ddf52
tweaks: add a supporting variable, in order to condense some statements
2020-03-05 16:07:52 +01:00
ac61254581
tweaks: invert the logic of a symbol, to make more sense
...
Giving a name to the uncommon case is more fitting.
It also avoids a negation and allows to elide a condition.
2020-03-05 15:12:08 +01:00
9e182fde66
tweaks: swap the use of 'head' and 'tail' for CUT and PASTE undo items
...
Now the 'head' endpoint is closer to the top of the buffer, and the
'tail' endpoint closer to the bottom. That makes more sense.
2020-03-05 14:52:02 +01:00
70d59ffe16
tweaks: remove a redundant assignment
...
Consecutive additions all happen on the same line. When automatic
hard-wrapping occurs, the ADD item is grouped together with an ENTER
item, and subsequent additions go into a new ADD item.
2020-03-05 13:32:20 +01:00
fb4bcd8cfd
undo: store the cursor row, for redoing filtering & justification better
...
This fixes https://savannah.gnu.org/bugs/?57958 .
2020-03-05 12:34:55 +01:00
2288abcd49
tweaks: use the variable that suits 'END' better
2020-03-05 12:34:17 +01:00
89217f20af
tweaks: rename two symbols, to be more precise
2020-03-02 17:16:07 +01:00
477a9b33b4
files: when piping, always pipe whatever was cut to the external command
...
Either the marked region was cut (even when zero characters) or
the entire contents of the buffer were cut. In both cases this
is what needs to be piped to the command. That is: the contents
of the cutbuffer.
This fixes https://savannah.gnu.org/bugs/?57931 .
Bug existed since version 2.9.8, commit f304b9ae
2020-03-02 13:36:56 +01:00
4409b275fc
tweaks: avoid a complaint about uninitialized memory [valgrind]
...
This addresses https://savannah.gnu.org/bugs/?57932 .
2020-03-01 17:08:50 +01:00
8848ac5a9b
undo: do not try to copy a cutbuffer that is NULL
...
Allow the creation of an empty CUT undo item (because the result of a
filtering operation may be empty), but then don't crash when undoing
such an empty CUT.
This fixes https://savannah.gnu.org/bugs/?57929 .
Bug existed since version 2.9.8, when filtering was introduced.
2020-03-01 12:59:54 +01:00
c055e629c7
tweaks: copy and store a deleted character in a conciser manner
2020-02-28 19:24:31 +01:00
e6f26464d7
tweaks: add calls of die() for five theoretical programming mistakes
2020-02-28 19:15:23 +01:00
a0aeeba075
tweaks: remove two redundant case labels
...
The add_undo() and update_undo() functions are never called with
JOIN as argument, so there is no need to have a case label for it.
2020-02-28 19:05:09 +01:00
c640a55b1c
tweaks: frob a statement, rewrap two lines, and remove a pair of braces
2020-02-28 18:59:04 +01:00
7d0b7e47c1
undo: use the correct original fusion point when unjoining two lines
...
When a <Backspace> did the join, 'head' and 'tail' are not the same.
This fixes https://savannah.gnu.org/bugs/?57916 .
Bug existed since commit 7cf08b93
2020-02-28 17:09:03 +01:00
132ed5c8f0
tweaks: instead of swapping the end points later, assign them correctly
...
(This also makes it clear that the naming of 'head' and 'tail'
is the wrong way around for CUT too.)
2020-02-28 15:25:23 +01:00
Benno Schulenberg