d42f71a2ef
tweaks: avoid a few needless reallocations
...
Most of these variables are freed moments later -- reallocating
them is thus a waste of time.
2017-03-20 13:07:57 +01:00
f48e15f2a3
tweaks: rename and shorten a small helper function
2017-03-20 12:24:42 +01:00
892762d99c
tweaks: rename some variables, to show they refer to screen rows
2017-01-12 18:03:36 +01:00
f7d320d932
tweaks: rename a function, to show it refers to screen rows
2017-01-12 17:48:33 +01:00
61bc248555
tweaks: chuck a couple of useless asserts
2017-01-08 15:27:48 +01:00
fd0589d8bc
tweaks: remove the cluttering conditional compilation of a parameter
...
The conditionalizing saved negligible amounts of space, of memory, and
of speed.
2017-01-03 14:11:45 +01:00
a381021ffc
tweaks: when allow_tabs is FALSE, allow_files is irrelevant
...
In that case setting the latter to TRUE is misleading. So don't do that.
2017-01-03 14:02:52 +01:00
588daf949e
tweaks: condense the setting of three flags
2016-12-25 13:11:17 +01:00
e6350aaba4
prompt: do not treat a leading newline in a filename specially
...
This fixes https://savannah.gnu.org/bugs/?49884 .
2016-12-22 13:46:53 +01:00
8bf8682b17
binding: use the code for the Enter directly instead of a function call
...
And certainly don't return zero when the key wouldn't have been found,
because that would have meant jumping a word to the right.
2016-12-22 12:13:03 +01:00
a9b5a0e029
tweaks: rename a function to something less abbrevy
...
Also, swap the logic around, to use less braces.
2016-12-22 12:04:10 +01:00
0b0b812206
files: don't change embedded newlines into nulls in filenames
...
Because changing anything to a null effectively means to truncate
the name.
This fixes https://savannah.gnu.org/bugs/?49868
and fixes https://savannah.gnu.org/bugs/?49874 .
2016-12-18 11:37:57 +01:00
d7af590c6b
memory: don't bother making a snug fit for things that will be freed soon
...
Most full paths are needed only temporarily and will be freed within
milliseconds. Only 'full_operating_dir' and 'backup_dir' continue to
exist for the whole current session. Any partition, too, will soon be
unpartitioned, so the extra reallocation is just a waste of time.
2016-12-18 10:33:30 +01:00
8c7e4f5108
tweaks: rename a function to describe what it does
...
It doesn't align anything -- any allocations are already aligned to
whatever multiple is required -- it just shrinks the allocated space.
2016-12-18 10:30:35 +01:00
1144d38316
tweaks: don't bother reallocating a string of which there is only one
...
And which normally is just some ten or twenty characters long, and
never gets wildly overallocated.
2016-12-18 10:28:30 +01:00
b5400ffe65
general: gettextize three overlooked statusbar messages
...
This fixes https://savannah.gnu.org/bugs/?48622 .
2016-12-01 13:02:43 +01:00
09e95b2d91
tweaks: frob a few comments
2016-09-11 11:26:09 +02:00
03fd6f3af8
tweaks: remove a useless cursor movement
2016-09-11 10:43:21 +02:00
b92d35d1f2
browser: add the option showcursor, to place the cursor on the highlight
...
This lets users of braille displays find the selected item immediately.
This fulfills a request by Enrico Mioso.
See https://lists.gnu.org/archive/html/nano-devel/2016-09/msg00025.html .
2016-09-11 09:41:52 +02:00
2fd497e3ef
tweaks: remove a superfluous blanking of the statusbar
...
The prompt from which the browser was invoked has already blanked it.
2016-09-03 15:34:44 +02:00
514cd9a099
update the license text to the preferred version
...
Mentioning "GNU nano" instead of "This program" and referring to the
website instead of to a postal address.
2016-08-29 21:27:16 +02:00
406e5242a3
update the copyright notices
2016-08-29 21:27:05 +02:00
b77b1391c3
tweaks: improve some indentation and reshuffle a few lines
2016-08-26 12:24:18 +02:00
91951ab22a
input: don't bother putting a keycode into byte range
...
A keycode is either already in byte range (so there is nothing to do)
or it is not and it shouldn't be (so there is nothing to do either).
2016-07-30 12:19:47 +02:00
8b28de1313
tweaks: don't call a thing malloc... when it doesn't call malloc()
2016-07-13 15:04:40 +02:00
8fa72fb7e7
browser: elide a variable by fusing the uses of 'newpath' and 'path'
...
Signed-off-by: Rishabh Dave <rishabhddave@gmail.com>
2016-07-13 14:30:18 +02:00
62eeda3e9f
tweaks: use mallocstrcpy() instead of strdup(), for a graceful death
...
To make nano save its modified buffers when it runs out of memory.
2016-07-11 20:45:26 +02:00
a730b25ef9
browser: elide another call of opendir()
...
And in the bargain show an error message when doing ^R unreadabledir ^T.
2016-07-04 21:18:09 +02:00
03a81aa9c5
browser: trim all trailing slashes (just in case there are more)
2016-07-03 16:18:26 +02:00
4957c1121d
browser: select an inaccessible directory also when tabbed
...
When the user tab-completed a name at the Go To Directory prompt, this
name will end in a slash. Remove this slash, so the name can be found
in the file list (where directory names don't include the final slash).
This fixes http://savannah.gnu.org/bugs/?48353 .
Signed-off-by: Rishabh Dave <rishabhddave@gmail.com>
2016-07-02 12:26:42 +02:00
d9d8eb2480
tweaks: straighten out the flow of a loop
2016-07-01 13:11:23 +02:00
d9aad9212f
tweaks: elide a bit of code duplication
2016-07-01 13:11:00 +02:00
8b636de1d3
tweaks: put all the movement functions together
...
And order them from smallest stride to biggest stride.
2016-07-01 12:42:58 +02:00
aeab800490
tweaks: improve a few comments
2016-07-01 12:34:33 +02:00
f8c33e8630
tweaks: reduce the scope of two variables
2016-07-01 12:22:44 +02:00
559858a3dd
browser: don't seem to enter a directory when it is inaccessible
...
This fixes https://savannah.gnu.org/bugs/?48286 .
Reviewed-by: Benno Schulenberg <bensberg@justemail.net>
Signed-off-by: Rishabh Dave <rishabhddave@gmail.com>
2016-06-26 10:14:12 +02:00
c0c30731c4
browser: don't use a term that is not explained in the documentation
...
Also, other messages that are about --operatingdir don't use the term
"confined" either.
Suggested-by: Mario Blättermann <mario.blaettermann@gmail.com>
2016-06-24 09:24:00 +02:00
9106cc8ecc
main: let the main loop restore the main menu, if needed
...
Don't make it the responsibility of the executed functions to restore
the list of shortcuts of the edit window. Just detect whether another
menu was displayed, and if so, redisplay the main menu.
2016-06-21 11:03:38 +02:00
956fead2e1
browser: show an error message when selecting an inaccessible directory
...
This fixes https://savannah.gnu.org/bugs/?48007 .
Tested-by: Rishabh Dave <rishabhddave@gmail.com>
Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
2016-06-13 11:15:20 +02:00
17cf833b9c
tweaks: normalize some whitespace
2016-05-30 09:09:36 +02:00
1d3d30776a
tweaks: more consistently use * instead of [0] when checking for '\0'
2016-05-27 21:31:55 +02:00
d3bd855c9d
tweaks: rename a function, and move the sorting there too
2016-05-25 12:09:22 +02:00
bd3f156044
browser: move all openings and closings of a directory to the same function
...
Signed-off-by: Rishabh Dave <rishabhddave@gmail.com>
Signed-off-by: Benno Schulenberg <bensberg@justemail.net>
2016-05-25 12:02:33 +02:00
fbb6208d15
browser, files: use full path in error message when in confined mode
...
The relative path could be . or .. or even empty, which is uninformative.
This fixes the last part of https://savannah.gnu.org/bugs/?47798 .
2016-05-22 11:41:58 +02:00
2e75c22759
browser: fix a memory leak
2016-05-21 21:35:02 +02:00
9576eb62e6
browser: show a message when getcwd() fails, instead of just beeping
2016-05-21 21:34:25 +02:00
c8f530af93
statusbar: add a non-beeping message type that does not get overwritten
...
Error messages about lock files should not get overwritten by purely
informational messages, only by alerting ones.
This fixes https://savannah.gnu.org/bugs/?47963 .
2016-05-21 13:58:09 +02:00
d7d3a87624
tweaks: elide an unneeded variable
2016-05-17 21:29:44 +02:00
c03ce956c8
browser: after getting a mouse click, don't try any further interpretation
...
Either the selected file was changed, or a file or directory was chosen
(and the Enter key virtually pressed), or a shortcut was executed. So,
just go and read the next key.
This fixes https://savannah.gnu.org/bugs/?47944 .
2016-05-17 17:49:15 +02:00
eedec06cc4
tweaks: fix compilation when configured with --enable-tiny --enable-browser
2016-05-17 12:48:47 +02:00
Benno Schulenberg