Benno Schulenberg
415bf82690
tweaks: move an 'if' and then remove an unneeded label
2018-03-26 08:52:04 +02:00
Benno Schulenberg
9bce8bfeb3
build: fix compilation when configured with --disable-multibuffer
2018-03-23 19:14:56 +01:00
Benno Schulenberg
2c024a74a9
tweaks: adjust or correct some comments, and rename a function
...
Also, reshuffle a condition so it takes up less space.
2018-03-23 17:54:06 +01:00
Benno Schulenberg
ab8698df47
tweaks: condense some code, to remove a bit of duplication
2018-03-23 17:14:39 +01:00
Benno Schulenberg
206d89b739
tweaks: revert commit c88a2fd9
-- the extra variable is needed
...
This variable will be modified by go_forward_chunks(), but the value
of openfile->current itself should be maintained.
2018-03-23 11:31:08 +01:00
Benno Schulenberg
eff2e0e291
help: describe the Scroll-Up and Scroll-Down commands more precisely
...
An "if possible" would have been nice, but there is no room for that.
2018-03-23 11:10:19 +01:00
Benno Schulenberg
c5e20164c3
tweaks: rewrap and amend some lines in the NEWS file
2018-03-23 11:09:59 +01:00
Benno Schulenberg
0f1f53a441
tweaks: drop a handful of unhelpful asserts
2018-03-23 11:09:56 +01:00
Benno Schulenberg
bf1a080923
build: exclude more things when configured with --disable-multibuffer
...
This will make the tiny version slightly smaller.
2018-03-23 11:09:37 +01:00
Benno Schulenberg
b7f8d4819b
tweaks: frob some comments plus miscellaneous other stuff
2018-03-22 19:54:20 +01:00
Benno Schulenberg
30fc197b66
tweaks: adjust a couple of types, to reduce the number of warnings
...
This avoids eleven warnings of the kind "comparison between signed
and unsigned integer expressions [-Wsign-compare]".
2018-03-22 19:33:22 +01:00
Benno Schulenberg
c88a2fd9ca
tweaks: elide an unneeded and shadowing variable
2018-03-22 15:20:05 +01:00
Benno Schulenberg
b9de5525c4
tweaks: elide a parameter, as it's always the inverse of another
2018-03-22 12:52:28 +01:00
Benno Schulenberg
f4d1ef1c4e
tweaks: remove unneeded settings and unsettings of MULTIBUFFER
...
In the preceding commit, open_buffer() was changed so that it gets
told whether to load into a new buffer or not, so it is no longer
needed to convey this information through a flag.
2018-03-22 12:50:48 +01:00
Benno Schulenberg
dd157f1494
tweaks: change a parameter of open_buffer() and invert its logic
2018-03-22 12:35:50 +01:00
Benno Schulenberg
624918800b
tweaks: bundle some settings for a new buffer
2018-03-22 12:27:04 +01:00
Benno Schulenberg
8b8c6bb818
tweaks: factor out the check for 'viewok' into its own function
...
And also prevent a theoretical crash for restricted prompt functions.
2018-03-20 20:10:08 +01:00
Kamil Dudka
b830a7dd38
input: do not crash if sctofunc() returns NULL
...
This fixes a regression introduced by commit 54103d8e: a crash that
can be triggered by running 'nano --restrict' and pressing <Insert>.
This addresses https://bugzilla.redhat.com/1558532 .
2018-03-20 19:36:55 +01:00
Benno Schulenberg
3e5b0ea5fd
files: prevent an infinite loop when reading from standard input fails
2018-03-20 11:25:16 +01:00
Benno Schulenberg
a1132c81a1
files: prevent the undo of reading a file into a new buffer
...
When the file has just been read, it is in the state that it has
on disk, so there is nothing to undo.
This fixes https://savannah.gnu.org/bugs/?53387 .
2018-03-20 11:14:55 +01:00
Liu Hao
0496aed4ab
build: fix compilation error when configured with --disable-justify
...
Signed-off-by: Liu Hao <lh_mouse@126.com>
2018-03-19 13:39:15 +01:00
Benno Schulenberg
373e3b880f
scrolling: first move the cursor before pushing current chunk offscreen
...
When the cursor is on the first or last row of the edit window, and
thus Scroll-Down or Scroll-Up would push it offscreen, first move
the cursor away from the edge row and then scroll.
This fixes https://savannah.gnu.org/bugs/?53376 .
2018-03-18 20:06:29 +01:00
David Lawrence Ramsey
7b1f3f4fe7
tweaks: correct several parameter types
...
This avoids a bunch of warnings when compiled with -pedantic:
ISO C forbids comparison of ‘void *’ with function pointer
2018-03-18 20:01:25 +01:00
Benno Schulenberg
9517972b58
build: fix compilation again when configured with --enable-tiny
2018-03-18 16:33:21 +01:00
Benno Schulenberg
95989e7dfe
selecting: don't cancel a softmark when just scrolling the screen
...
As, since commit 0e30177d
, the scrollup and scrolldown commands
no longer intend to move the cursor, they should not be seen as
movement functions.
Also, it is not guaranteed that functions are ordered in the same
way in the binary as in the source code, so an ordered comparison
of function pointers will not always work.
This fixes https://savannah.gnu.org/bugs/?53333 .
2018-03-18 13:55:29 +01:00
Benno Schulenberg
dcda98fb73
tweaks: remove an inconsistent space from two pointer declarations
...
Reported-by: Brand Huntsman <alpha@qzx.com>
2018-03-17 15:53:22 +01:00
Benno Schulenberg
336fa40055
docs: clarify what the scrollup and scrolldown bindable functions do
2018-03-17 14:27:23 +01:00
Benno Schulenberg
93318b972d
tweaks: elide two parameters and thus a pair of wrapper functions
...
When just scrolling and the cursor does not need to change position
(that is: it is not on the first or last row of the edit window),
then edit_scroll() has handled everything and there is no need to
additionally redraw anything or update 'placewewant'.
2018-03-17 14:07:42 +01:00
Benno Schulenberg
8656f160d7
tweaks: reshuffle some movement code, to reduce the number of conditions
...
Also, rename a parameter and invert its logic.
2018-03-17 14:02:55 +01:00
Benno Schulenberg
0e30177db7
scrolling: let Scroll-Up/Down keep the cursor in the same text position
...
Instead of keeping the cursor in the same spot on the screen,
let the cursor move with the text (whenever possible).
This makes these functions behave the same as in Vim and Emacs.
2018-03-17 14:00:00 +01:00
Benno Schulenberg
3089a98169
tweaks: fix a typo and adjust some wording and formatting in the FAQ
2018-03-12 11:43:43 +01:00
Benno Schulenberg
1b704e7c8c
tweaks: reduce the font size of the questions in the FAQ
...
Make them smaller to make them sound less like shouting.
2018-03-12 11:25:03 +01:00
Benno Schulenberg
efb9192ee5
docs: mention in the FAQ that <Shift+Insert> pastes from the clipboard
...
This kind of addresses https://savannah.gnu.org/bugs/?53310 .
2018-03-12 11:21:26 +01:00
Benno Schulenberg
f0734dae3e
cut: avoid calling renumber() on what might be NULL
...
This fixes https://savannah.gnu.org/bugs/?53317 .
Reported-by: David Lawrence Ramsey <pooka109@gmail.com>
2018-03-12 10:46:02 +01:00
Benno Schulenberg
e8505b2d3e
memory: plug a leak, by actually freeing a discarded undo struct
...
This fixes https://savannah.gnu.org/bugs/?53269 .
Reported-by: Ashish Kunwar <dorkerdevil280@gmail.com>
The leak was mistakenly introduced by commit dc3618a1
-- probably as a leftover of testing things.
2018-03-11 20:16:09 +01:00
Benno Schulenberg
1ebb1da382
tweaks: elide a parameter that is always 1
...
And adjust the comments accordingly.
2018-03-10 12:43:33 +01:00
Benno Schulenberg
1fb3218a14
help: do not reserve space for line numbers, as they are absent
...
Help texts are shown without any line numbers, so the full width
of the screen should be used to display the text.
This fixes https://savannah.gnu.org/bugs/?53308 .
2018-03-09 12:03:48 +01:00
Benno Schulenberg
a7b1f0f03f
po: update translations and regenerate POT file and PO files
2018-03-08 11:11:05 +01:00
Benno Schulenberg
c782b4cb72
bump version numbers and add a news item for the 2.9.4 release
2018-03-08 10:59:32 +01:00
Benno Schulenberg
5234475781
gnulib: update to its current upstream state
2018-03-06 12:07:30 +01:00
Benno Schulenberg
80605c3918
tweaks: exclude an unlikely warning from the tiny version
2018-03-06 12:05:52 +01:00
Benno Schulenberg
d3012be095
tweaks: don't call strcmp() to determine whether a string is empty
2018-03-06 11:59:03 +01:00
Brand Huntsman
03bc19fd0c
color: remove unneeded bright comparision to prevent duplicate pairs
...
Signed-off-by: Brand Huntsman <alpha@qzx.com>
2018-03-05 20:03:03 +01:00
Benno Schulenberg
e4cef3086b
tweaks: drop an assert, add a warning, and change a 'for' to a 'while'
2018-03-05 12:46:25 +01:00
Benno Schulenberg
9936a6357a
tweaks: rename a parameter and a variable, to be more fitting
2018-03-05 12:46:25 +01:00
Benno Schulenberg
899bf0ae3a
tweaks: exclude an unlikely error message from the tiny version
2018-03-05 12:45:19 +01:00
Benno Schulenberg
1f7384ebd2
tweaks: appease valgrind concerning syscalls with uninitialized values
2018-03-05 11:02:52 +01:00
Benno Schulenberg
95fffa99aa
tweaks: adjust two comments, move two declarations, rewrap three lines
2018-03-05 10:43:05 +01:00
Benno Schulenberg
22f7861694
tweaks: reshuffle the undo types into mostly the same order everywhere
...
First the two that add something (ADD, ENTER), then the three that
delete something (BACK, DEL, JOIN), and then the one that changes
something (REPLACE). Then the SPLITs, CUT, PASTE, and INSERT, and
then the INDENTs and COMMENTs, when they exist.
2018-03-05 10:05:07 +01:00
Benno Schulenberg
ba96d507dd
tweaks: drop some debugging stuff, and adjust what remains of it
2018-03-05 09:42:57 +01:00