67873e961b
cutting: cover the corner cases where cut commands do not cut anything
...
Give the correct feedback in those cases and do not add an undo item.
This fixes both parts of https://savannah.gnu.org/bugs/?55396 .
2019-01-06 13:07:20 +01:00
50e8f8aab9
cutting: give feedback when otherwise nothing happens
...
This makes the cutting and pasting keystrokes somewhat discoverable.
2019-01-05 17:39:05 +01:00
ce6f320947
cutting: when ^K does not actually cut anything, do not add an undo item
...
Act the same way for M-T and for zapping.
This addresses https://savannah.gnu.org/bugs/?55330 .
2019-01-05 17:36:34 +01:00
4104376e7c
tweaks: rename a variable, elide another, and adjust two comments
...
Also, adjust the type of a parameter to 'size_t', as it is a
character index.
2019-01-02 18:05:58 +01:00
ffa0a9ef64
tweaks: calculate the length of a completion word in a more direct way
2019-01-02 17:44:15 +01:00
eef6b2b442
tweaks: use proper variable types in the word-completion functions
...
Use 'size_t' for character indexes, and 'ssize_t' for the threshold.
2019-01-01 17:48:23 +01:00
16c20ad873
tweaks: move the character/word-deletion functions to a better location
...
Having all the cutting and deleting functions together in one file
kind of makes sense.
2019-01-01 17:48:02 +01:00
f9bb5382aa
tweaks: reshuffle and frob a couple of comments, and reindent two lines
2019-01-01 17:33:10 +01:00
329b82d284
undo: set the correct file size for a redo of a character deletion
...
The reduced file size should be stored not just when joining two lines
but also when simply a character in the middle of a line is deleted.
This fixes https://savannah.gnu.org/bugs/?55352 .
Bug existed since version 2.5.0, commit 66e21416
2019-01-01 12:35:53 +01:00
b596639f95
options: actually rename --rebindkeypad to --rawsequences (-K)
2018-12-31 18:35:46 +01:00
d0982536a7
undo: after undoing a cut, don't remove the magicline if we're on it
...
This fixes https://savannah.gnu.org/bugs/?55332 .
2018-12-31 14:10:02 +01:00
798695ff1e
utils: retire the fixbounds() function -- it is no longer needed
...
All tested systems (FreeBSD, NetBSD, OpenBSD, Alpine, and Ubuntu)
support the GNU-style word boundaries (\< and \>), either natively
or through using the regex module from gnulib.
If this change breaks regexes containing \< or \> on your system,
please report a bug: https://savannah.gnu.org/bugs/?group=nano
This addresses https://savannah.gnu.org/bugs/?55207 .
2018-12-31 13:49:07 +01:00
15320d3b96
tweaks: word some comments more concisely
2018-12-30 21:30:26 +01:00
0e9fb6a0da
tweaks: rename two variables, to be more descriptive
2018-12-30 20:18:29 +01:00
34b8d58871
rcfile: reject an attempt to bind ^[
...
Also, for <Esc> <Esc> [, report that it is unbindable.
This fixes https://savannah.gnu.org/bugs/?55336 .
2018-12-30 19:47:43 +01:00
fb4ce71cfc
tweaks: correct a comment typo, and trim a few other comments
2018-12-30 18:00:28 +01:00
7a2c851dfc
tweaks: reorder some ifs, to reduce the average number of comparisons
2018-12-30 17:50:10 +01:00
4d55748999
tweaks: reduce a bunch of repetitious comments to their essence
...
And in the bargain add two missing equivalences.
2018-12-30 17:31:36 +01:00
e7198f49a4
tweaks: elide an unneeded intermediate variable
2018-12-30 16:48:48 +01:00
125cc0cd74
tweaks: elide a tiny function by making a variable global
...
And in the bargain it makes things clearer, because the name
cutbuffer_reset() is misleading.
2018-12-30 13:36:29 +01:00
afab65e8a8
tweaks: elide a parameter that is always TRUE
...
The parameter was made redundant by David's overhaul of the
justification code.
2018-12-30 12:48:26 +01:00
7e152f2a48
undo: when undoing a cut, remove also the magicline if it added one
...
Reuse the WAS_FINAL_LINE flag to signal a cut that added a magicline,
for both a marked cut and cut-to-eof.
This fixes https://savannah.gnu.org/bugs/?55305 .
2018-12-30 11:37:46 +01:00
8854ddb728
undo: set and check 'xflags' in a bitwise manner
...
This allows multiple flags to be set, which will be needed for the
next commit.
2018-12-30 11:36:49 +01:00
0213f412d1
docs: say that --rebinddelete can correct both <Backspace> and <Delete>
2018-12-28 19:48:54 +01:00
dc99610c36
docs: reword and reshuffle the description of --rawsequences
...
It's not just about the numeric keypad, but about the interpretation
of all editing keys (arrows, Home, End, PageUp, PageDown, Insert, and
Delete), of the escape sequences that they produce.
2018-12-28 19:29:38 +01:00
d3c0fe3923
options: make --rawsequences disable --mouse, to prevent entering junk
...
When using --raw, ncurses does not catch and convert any mouse event,
and thus the coordinates of a mouse click would get inserted into the
buffer as seemingly random characters. So, let --rawsequences override
and disable --mouse, to prevent the accidental entering of junk.
This fixes https://savannah.gnu.org/bugs/?55303 .
2018-12-28 19:15:20 +01:00
997826d794
tweaks: rename a symbol, to match its corresponding option
2018-12-28 17:47:03 +01:00
67c69b2298
options: rename long version of -K from --rebindkeypad to --rawsequences
...
To better describe what it does, and to have full contrast with the
--rebinddelete option: the latter can now be shortened to --rebind
without getting a conflict, and --rawsequences can be abbreviated
to simply --raw and still make sense.
2018-12-28 17:35:55 +01:00
72a49dbbb4
browser, help: make <Bsp> page up also when terminfo mismatches terminal
2018-12-28 17:20:24 +01:00
0946153b47
tweaks: hard-bind ASCII DEL in a slightly more economical way
...
And in the bargain get rid of a duplicate help-text entry for
either "Del" or "Bsp".
2018-12-28 17:20:18 +01:00
9b2c2697cb
options: make -d (--rebinddelete) work without -K (--rebindkeypad)
...
When the terminfo selected by TERM does not match the terminal and
the <Delete> key behaves the same as <Backspace> (deleting leftward)
or the <Backspace> key behaves the same as <Delete> (deleting without
moving the cursor), then using just -d or --rebinddelete should make
the deviant key behave correctly again without affecting the other.
2018-12-28 17:19:09 +01:00
a57c6a6763
tweaks: elide a one-line function that is used just twice
2018-12-27 21:19:47 +01:00
597d90207e
startup: improve two error messages by mentioning the invalid operand
...
This addresses https://savannah.gnu.org/bugs/?55304 .
2018-12-27 21:08:57 +01:00
b1b2369541
tweaks: rewrap a line and improve a few comments
2018-12-26 15:11:20 +01:00
8a88cea256
tweaks: elide a variable that is a copy of another
2018-12-26 14:56:29 +01:00
6f23d9c18c
tweaks: rename a variable, because it also serves as "last line"
2018-12-26 14:37:36 +01:00
dfbffff4b0
tweaks: remove a superfluous incrementing and decrementing of a variable
2018-12-26 14:28:54 +01:00
ea73d7fd70
tweaks: condense a couple of comments and rewrap a few lines
2018-12-26 14:26:54 +01:00
55c52c50d0
bindings: hard-bind ASCII code 0x08 (BS) to the backspace function
...
ASCII code BS should always do a backspace, also on systems where the
"^H" string gets redirected (for rebinding purposes) to KEY_BACKSPACE.
This fixes https://savannah.gnu.org/bugs/?55247 .
Reported-by: Norton Warner <nortonwarner@gmail.com>
2018-12-23 18:45:12 +01:00
77bd8c2630
tweaks: swap the names of the variables 'wrap_at' and 'fill'
...
Now 'fill' contains the original specified value,
and 'wrap_at' the column that 'fill' translates to.
2018-12-18 19:50:59 +01:00
3121ee4b2e
options: stop recognizing and mentioning --quiet and 'set quiet'
...
Those options have been a no-op and obsolete for over a year.
Just continue to accept and ignore -q, for some "compatibility"
with Pico.
2018-12-18 19:29:40 +01:00
762cee242a
tweaks: reshuffle a bit of code, to have the exit point near the end
2018-12-18 19:27:17 +01:00
3a170d2c3e
rcfile: when rebound, DO unbind a keystroke from its earlier function
...
When not unbinding it from its earlier function (in the same menu),
it would result in showing the keystroke twice in the help text.
This fixes https://savannah.gnu.org/bugs/?55239 .
Bug was introduced a month ago, by commit f81d174f
2018-12-18 19:25:33 +01:00
e8751d1d5c
bindings: make the normal scrolling keystrokes work also in help viewer
...
There is no reason why they shouldn't work.
2018-12-17 17:05:56 +01:00
9dd6407bea
docs: correct the descriptions of 'speller' and 'linter' functions
...
Since the last release, the linter function is bound separately and
no longer masks or overrides the speller function.
2018-12-17 16:05:35 +01:00
670dd9bbe0
tweaks: condense two regexes in the Tcl syntax, and add a comment
...
Also, make a range of characters more explicit.
2018-12-17 16:00:54 +01:00
9cdc64c97a
syntax: tcl: colorize comments normally, not with a background hue
...
This makes for a less "messy" and more readable appearance.
Suggested-by: Michael Siegel <msi@malbolge.net>
2018-12-17 15:35:56 +01:00
5acfa5bb7b
tweaks: slightly indent warnings and errors during the configure phase
...
To make them stand out in the waterfall of messages.
2018-12-16 14:41:31 +01:00
38ca2a41f4
tweaks: reduce the scope of two variables, and rename one of them
...
Also, swap the order of the 'if', and don't bother setting a freed
string pointer to NULL as it will never be used again.
2018-12-11 10:59:12 +01:00
6e3b9ac058
options: exit on a bad quoting regex, instead of crashing later
...
The paragraph-jumping functions used the regex unverified...
This fixes https://savannah.gnu.org/bugs/?55169 .
2018-12-11 10:29:29 +01:00
Benno Schulenberg