diff --git a/app/controllers/api/v1/polls/votes_controller.rb b/app/controllers/api/v1/polls/votes_controller.rb
new file mode 100644
index 0000000000..3fa0b6a760
--- /dev/null
+++ b/app/controllers/api/v1/polls/votes_controller.rb
@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+class Api::V1::Polls::VotesController < Api::BaseController
+ include Authorization
+
+ before_action -> { doorkeeper_authorize! :write, :'write:statuses' }
+ before_action :require_user!
+ before_action :set_poll
+
+ respond_to :json
+
+ def create
+ VoteService.new.call(current_account, @poll, vote_params[:choices])
+ render json: @poll, serializer: REST::PollSerializer
+ end
+
+ private
+
+ def set_poll
+ @poll = Poll.attached.find(params[:poll_id])
+ authorize @poll.status, :show?
+ rescue Mastodon::NotPermittedError
+ raise ActiveRecord::RecordNotFound
+ end
+
+ def vote_params
+ params.permit(choices: [])
+ end
+end
diff --git a/app/controllers/api/v1/polls_controller.rb b/app/controllers/api/v1/polls_controller.rb
new file mode 100644
index 0000000000..4f4a6858db
--- /dev/null
+++ b/app/controllers/api/v1/polls_controller.rb
@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+class Api::V1::PollsController < Api::BaseController
+ before_action -> { authorize_if_got_token! :read, :'read:statuses' }, only: :show
+
+ respond_to :json
+
+ def show
+ @poll = Poll.attached.find(params[:id])
+ ActivityPub::FetchRemotePollService.new.call(@poll, current_account) if user_signed_in? && @poll.possibly_stale?
+ render json: @poll, serializer: REST::PollSerializer, include_results: true
+ end
+end
diff --git a/app/controllers/api/v1/statuses_controller.rb b/app/controllers/api/v1/statuses_controller.rb
index 29b420c675..f9506971a0 100644
--- a/app/controllers/api/v1/statuses_controller.rb
+++ b/app/controllers/api/v1/statuses_controller.rb
@@ -53,6 +53,7 @@ class Api::V1::StatusesController < Api::BaseController
visibility: status_params[:visibility],
scheduled_at: status_params[:scheduled_at],
application: doorkeeper_token.application,
+ poll: status_params[:poll],
idempotency: request.headers['Idempotency-Key'])
render json: @status, serializer: @status.is_a?(ScheduledStatus) ? REST::ScheduledStatusSerializer : REST::StatusSerializer
@@ -73,12 +74,25 @@ class Api::V1::StatusesController < Api::BaseController
@status = Status.find(params[:id])
authorize @status, :show?
rescue Mastodon::NotPermittedError
- # Reraise in order to get a 404 instead of a 403 error code
raise ActiveRecord::RecordNotFound
end
def status_params
- params.permit(:status, :in_reply_to_id, :sensitive, :spoiler_text, :visibility, :scheduled_at, media_ids: [])
+ params.permit(
+ :status,
+ :in_reply_to_id,
+ :sensitive,
+ :spoiler_text,
+ :visibility,
+ :scheduled_at,
+ media_ids: [],
+ poll: [
+ :multiple,
+ :hide_totals,
+ :expires_in,
+ options: [],
+ ]
+ )
end
def pagination_params(core_params)
diff --git a/app/javascript/mastodon/actions/importer/index.js b/app/javascript/mastodon/actions/importer/index.js
index 931711f4b0..13ad5d1e11 100644
--- a/app/javascript/mastodon/actions/importer/index.js
+++ b/app/javascript/mastodon/actions/importer/index.js
@@ -1,11 +1,10 @@
-// import { autoPlayGif } from '../../initial_state';
-// import { putAccounts, putStatuses } from '../../storage/modifier';
import { normalizeAccount, normalizeStatus } from './normalizer';
-export const ACCOUNT_IMPORT = 'ACCOUNT_IMPORT';
+export const ACCOUNT_IMPORT = 'ACCOUNT_IMPORT';
export const ACCOUNTS_IMPORT = 'ACCOUNTS_IMPORT';
-export const STATUS_IMPORT = 'STATUS_IMPORT';
+export const STATUS_IMPORT = 'STATUS_IMPORT';
export const STATUSES_IMPORT = 'STATUSES_IMPORT';
+export const POLLS_IMPORT = 'POLLS_IMPORT';
function pushUnique(array, object) {
if (array.every(element => element.id !== object.id)) {
@@ -29,6 +28,10 @@ export function importStatuses(statuses) {
return { type: STATUSES_IMPORT, statuses };
}
+export function importPolls(polls) {
+ return { type: POLLS_IMPORT, polls };
+}
+
export function importFetchedAccount(account) {
return importFetchedAccounts([account]);
}
@@ -45,7 +48,6 @@ export function importFetchedAccounts(accounts) {
}
accounts.forEach(processAccount);
- //putAccounts(normalAccounts, !autoPlayGif);
return importAccounts(normalAccounts);
}
@@ -58,6 +60,7 @@ export function importFetchedStatuses(statuses) {
return (dispatch, getState) => {
const accounts = [];
const normalStatuses = [];
+ const polls = [];
function processStatus(status) {
pushUnique(normalStatuses, normalizeStatus(status, getState().getIn(['statuses', status.id])));
@@ -66,12 +69,16 @@ export function importFetchedStatuses(statuses) {
if (status.reblog && status.reblog.id) {
processStatus(status.reblog);
}
+
+ if (status.poll && status.poll.id) {
+ pushUnique(polls, status.poll);
+ }
}
statuses.forEach(processStatus);
- //putStatuses(normalStatuses);
dispatch(importFetchedAccounts(accounts));
dispatch(importStatuses(normalStatuses));
+ dispatch(importPolls(polls));
};
}
diff --git a/app/javascript/mastodon/actions/importer/normalizer.js b/app/javascript/mastodon/actions/importer/normalizer.js
index 34a4150fac..3085cd5377 100644
--- a/app/javascript/mastodon/actions/importer/normalizer.js
+++ b/app/javascript/mastodon/actions/importer/normalizer.js
@@ -43,6 +43,10 @@ export function normalizeStatus(status, normalOldStatus) {
normalStatus.reblog = status.reblog.id;
}
+ if (status.poll && status.poll.id) {
+ normalStatus.poll = status.poll.id;
+ }
+
// Only calculate these values when status first encountered
// Otherwise keep the ones already in the reducer
if (normalOldStatus) {
diff --git a/app/javascript/mastodon/actions/polls.js b/app/javascript/mastodon/actions/polls.js
new file mode 100644
index 0000000000..bee4c48a69
--- /dev/null
+++ b/app/javascript/mastodon/actions/polls.js
@@ -0,0 +1,53 @@
+import api from '../api';
+
+export const POLL_VOTE_REQUEST = 'POLL_VOTE_REQUEST';
+export const POLL_VOTE_SUCCESS = 'POLL_VOTE_SUCCESS';
+export const POLL_VOTE_FAIL = 'POLL_VOTE_FAIL';
+
+export const POLL_FETCH_REQUEST = 'POLL_FETCH_REQUEST';
+export const POLL_FETCH_SUCCESS = 'POLL_FETCH_SUCCESS';
+export const POLL_FETCH_FAIL = 'POLL_FETCH_FAIL';
+
+export const vote = (pollId, choices) => (dispatch, getState) => {
+ dispatch(voteRequest());
+
+ api(getState).post(`/api/v1/polls/${pollId}/votes`, { choices })
+ .then(({ data }) => dispatch(voteSuccess(data)))
+ .catch(err => dispatch(voteFail(err)));
+};
+
+export const fetchPoll = pollId => (dispatch, getState) => {
+ dispatch(fetchPollRequest());
+
+ api(getState).get(`/api/v1/polls/${pollId}`)
+ .then(({ data }) => dispatch(fetchPollSuccess(data)))
+ .catch(err => dispatch(fetchPollFail(err)));
+};
+
+export const voteRequest = () => ({
+ type: POLL_VOTE_REQUEST,
+});
+
+export const voteSuccess = poll => ({
+ type: POLL_VOTE_SUCCESS,
+ poll,
+});
+
+export const voteFail = error => ({
+ type: POLL_VOTE_FAIL,
+ error,
+});
+
+export const fetchPollRequest = () => ({
+ type: POLL_FETCH_REQUEST,
+});
+
+export const fetchPollSuccess = poll => ({
+ type: POLL_FETCH_SUCCESS,
+ poll,
+});
+
+export const fetchPollFail = error => ({
+ type: POLL_FETCH_FAIL,
+ error,
+});
diff --git a/app/javascript/mastodon/components/poll.js b/app/javascript/mastodon/components/poll.js
new file mode 100644
index 0000000000..d4b9f283a3
--- /dev/null
+++ b/app/javascript/mastodon/components/poll.js
@@ -0,0 +1,144 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+import ImmutablePropTypes from 'react-immutable-proptypes';
+import ImmutablePureComponent from 'react-immutable-pure-component';
+import { defineMessages, injectIntl, FormattedMessage } from 'react-intl';
+import classNames from 'classnames';
+import { vote, fetchPoll } from 'mastodon/actions/polls';
+import Motion from 'mastodon/features/ui/util/optional_motion';
+import spring from 'react-motion/lib/spring';
+
+const messages = defineMessages({
+ moments: { id: 'time_remaining.moments', defaultMessage: 'Moments remaining' },
+ seconds: { id: 'time_remaining.seconds', defaultMessage: '{number, plural, one {# second} other {# seconds}} left' },
+ minutes: { id: 'time_remaining.minutes', defaultMessage: '{number, plural, one {# minute} other {# minutes}} left' },
+ hours: { id: 'time_remaining.hours', defaultMessage: '{number, plural, one {# hour} other {# hours}} left' },
+ days: { id: 'time_remaining.days', defaultMessage: '{number, plural, one {# day} other {# days}} left' },
+});
+
+const SECOND = 1000;
+const MINUTE = 1000 * 60;
+const HOUR = 1000 * 60 * 60;
+const DAY = 1000 * 60 * 60 * 24;
+
+const timeRemainingString = (intl, date, now) => {
+ const delta = date.getTime() - now;
+
+ let relativeTime;
+
+ if (delta < 10 * SECOND) {
+ relativeTime = intl.formatMessage(messages.moments);
+ } else if (delta < MINUTE) {
+ relativeTime = intl.formatMessage(messages.seconds, { number: Math.floor(delta / SECOND) });
+ } else if (delta < HOUR) {
+ relativeTime = intl.formatMessage(messages.minutes, { number: Math.floor(delta / MINUTE) });
+ } else if (delta < DAY) {
+ relativeTime = intl.formatMessage(messages.hours, { number: Math.floor(delta / HOUR) });
+ } else {
+ relativeTime = intl.formatMessage(messages.days, { number: Math.floor(delta / DAY) });
+ }
+
+ return relativeTime;
+};
+
+export default @injectIntl
+class Poll extends ImmutablePureComponent {
+
+ static propTypes = {
+ poll: ImmutablePropTypes.map.isRequired,
+ intl: PropTypes.object.isRequired,
+ dispatch: PropTypes.func,
+ disabled: PropTypes.bool,
+ };
+
+ state = {
+ selected: {},
+ };
+
+ handleOptionChange = e => {
+ const { target: { value } } = e;
+
+ if (this.props.poll.get('multiple')) {
+ const tmp = { ...this.state.selected };
+ tmp[value] = true;
+ this.setState({ selected: tmp });
+ } else {
+ const tmp = {};
+ tmp[value] = true;
+ this.setState({ selected: tmp });
+ }
+ };
+
+ handleVote = () => {
+ if (this.props.disabled) {
+ return;
+ }
+
+ this.props.dispatch(vote(this.props.poll.get('id'), Object.keys(this.state.selected)));
+ };
+
+ handleRefresh = () => {
+ if (this.props.disabled) {
+ return;
+ }
+
+ this.props.dispatch(fetchPoll(this.props.poll.get('id')));
+ };
+
+ renderOption (option, optionIndex) {
+ const { poll } = this.props;
+ const percent = (option.get('votes_count') / poll.get('votes_count')) * 100;
+ const leading = poll.get('options').filterNot(other => other.get('title') === option.get('title')).every(other => option.get('votes_count') > other.get('votes_count'));
+ const active = !!this.state.selected[`${optionIndex}`];
+ const showResults = poll.get('voted') || poll.get('expired');
+
+ return (
+
+ {showResults && (
+
+ {({ width }) =>
+
+ }
+
+ )}
+
+
+
+ );
+ }
+
+ render () {
+ const { poll, intl } = this.props;
+ const timeRemaining = timeRemainingString(intl, new Date(poll.get('expires_at')), intl.now());
+ const showResults = poll.get('voted') || poll.get('expired');
+ const disabled = this.props.disabled || Object.entries(this.state.selected).every(item => !item);
+
+ return (
+
+
+ {poll.get('options').map((option, i) => this.renderOption(option, i))}
+
+
+
+ {!showResults && }
+ {showResults && !this.props.disabled && · }
+ · {timeRemaining}
+
+
+ );
+ }
+
+}
diff --git a/app/javascript/mastodon/components/status.js b/app/javascript/mastodon/components/status.js
index 6270d3c92b..e10faedf87 100644
--- a/app/javascript/mastodon/components/status.js
+++ b/app/javascript/mastodon/components/status.js
@@ -16,6 +16,7 @@ import { MediaGallery, Video } from '../features/ui/util/async-components';
import { HotKeys } from 'react-hotkeys';
import classNames from 'classnames';
import Icon from 'mastodon/components/icon';
+import PollContainer from 'mastodon/containers/poll_container';
// We use the component (and not the container) since we do not want
// to use the progress bar to show download progress
@@ -270,7 +271,9 @@ class Status extends ImmutablePureComponent {
status = status.get('reblog');
}
- if (status.get('media_attachments').size > 0) {
+ if (status.get('poll')) {
+ media = ;
+ } else if (status.get('media_attachments').size > 0) {
if (this.props.muted || status.get('media_attachments').some(item => item.get('type') === 'unknown')) {
media = (
{
const componentName = component.getAttribute('data-component');
const Component = MEDIA_COMPONENTS[componentName];
- const { media, card, ...props } = JSON.parse(component.getAttribute('data-props'));
+ const { media, card, poll, ...props } = JSON.parse(component.getAttribute('data-props'));
Object.assign(props, {
...(media ? { media: fromJS(media) } : {}),
...(card ? { card: fromJS(card) } : {}),
+ ...(poll ? { poll: fromJS(poll) } : {}),
...(componentName === 'Video' ? {
onOpenVideo: this.handleOpenVideo,
diff --git a/app/javascript/mastodon/containers/poll_container.js b/app/javascript/mastodon/containers/poll_container.js
new file mode 100644
index 0000000000..cd7216de7a
--- /dev/null
+++ b/app/javascript/mastodon/containers/poll_container.js
@@ -0,0 +1,8 @@
+import { connect } from 'react-redux';
+import Poll from 'mastodon/components/poll';
+
+const mapStateToProps = (state, { pollId }) => ({
+ poll: state.getIn(['polls', pollId]),
+});
+
+export default connect(mapStateToProps)(Poll);
diff --git a/app/javascript/mastodon/features/status/components/detailed_status.js b/app/javascript/mastodon/features/status/components/detailed_status.js
index 49bc43a7ba..5cd50f055d 100644
--- a/app/javascript/mastodon/features/status/components/detailed_status.js
+++ b/app/javascript/mastodon/features/status/components/detailed_status.js
@@ -14,6 +14,7 @@ import Video from '../../video';
import scheduleIdleTask from '../../ui/util/schedule_idle_task';
import classNames from 'classnames';
import Icon from 'mastodon/components/icon';
+import PollContainer from 'mastodon/containers/poll_container';
export default class DetailedStatus extends ImmutablePureComponent {
@@ -105,7 +106,9 @@ export default class DetailedStatus extends ImmutablePureComponent {
outerStyle.height = `${this.state.height}px`;
}
- if (status.get('media_attachments').size > 0) {
+ if (status.get('poll')) {
+ media = ;
+ } else if (status.get('media_attachments').size > 0) {
if (status.get('media_attachments').some(item => item.get('type') === 'unknown')) {
media = ;
} else if (status.getIn(['media_attachments', 0, 'type']) === 'video') {
diff --git a/app/javascript/mastodon/reducers/index.js b/app/javascript/mastodon/reducers/index.js
index 0f0de849f7..a7e9c4d0fe 100644
--- a/app/javascript/mastodon/reducers/index.js
+++ b/app/javascript/mastodon/reducers/index.js
@@ -29,6 +29,7 @@ import listAdder from './list_adder';
import filters from './filters';
import conversations from './conversations';
import suggestions from './suggestions';
+import polls from './polls';
const reducers = {
dropdown_menu,
@@ -61,6 +62,7 @@ const reducers = {
filters,
conversations,
suggestions,
+ polls,
};
export default combineReducers(reducers);
diff --git a/app/javascript/mastodon/reducers/polls.js b/app/javascript/mastodon/reducers/polls.js
new file mode 100644
index 0000000000..53d9b1d8cb
--- /dev/null
+++ b/app/javascript/mastodon/reducers/polls.js
@@ -0,0 +1,19 @@
+import { POLL_VOTE_SUCCESS, POLL_FETCH_SUCCESS } from 'mastodon/actions/polls';
+import { POLLS_IMPORT } from 'mastodon/actions/importer';
+import { Map as ImmutableMap, fromJS } from 'immutable';
+
+const importPolls = (state, polls) => state.withMutations(map => polls.forEach(poll => map.set(poll.id, fromJS(poll))));
+
+const initialState = ImmutableMap();
+
+export default function polls(state = initialState, action) {
+ switch(action.type) {
+ case POLLS_IMPORT:
+ return importPolls(state, action.polls);
+ case POLL_VOTE_SUCCESS:
+ case POLL_FETCH_SUCCESS:
+ return importPolls(state, [action.poll]);
+ default:
+ return state;
+ }
+}
diff --git a/app/javascript/styles/application.scss b/app/javascript/styles/application.scss
index 4bce741876..6db3bc3dc9 100644
--- a/app/javascript/styles/application.scss
+++ b/app/javascript/styles/application.scss
@@ -16,6 +16,7 @@
@import 'mastodon/stream_entries';
@import 'mastodon/boost';
@import 'mastodon/components';
+@import 'mastodon/polls';
@import 'mastodon/introduction';
@import 'mastodon/modal';
@import 'mastodon/emoji_picker';
diff --git a/app/javascript/styles/mastodon/components.scss b/app/javascript/styles/mastodon/components.scss
index 0163e90b93..ceb28dd19f 100644
--- a/app/javascript/styles/mastodon/components.scss
+++ b/app/javascript/styles/mastodon/components.scss
@@ -105,6 +105,10 @@
border-color: lighten($ui-primary-color, 4%);
color: lighten($darker-text-color, 4%);
}
+
+ &:disabled {
+ opacity: 0.5;
+ }
}
&.button--block {
diff --git a/app/javascript/styles/mastodon/polls.scss b/app/javascript/styles/mastodon/polls.scss
new file mode 100644
index 0000000000..b93d36e928
--- /dev/null
+++ b/app/javascript/styles/mastodon/polls.scss
@@ -0,0 +1,95 @@
+.poll {
+ margin-top: 16px;
+ font-size: 14px;
+
+ li {
+ margin-bottom: 10px;
+ position: relative;
+ }
+
+ &__chart {
+ position: absolute;
+ top: 0;
+ left: 0;
+ height: 100%;
+ display: inline-block;
+ border-radius: 4px;
+ background: darken($ui-primary-color, 14%);
+
+ &.leading {
+ background: $ui-highlight-color;
+ }
+ }
+
+ &__text {
+ position: relative;
+ display: inline-block;
+ padding: 6px 0;
+ line-height: 18px;
+ cursor: default;
+
+ input[type=radio],
+ input[type=checkbox] {
+ display: none;
+ }
+
+ &.selectable {
+ cursor: pointer;
+ }
+ }
+
+ &__input {
+ display: inline-block;
+ position: relative;
+ border: 1px solid $ui-primary-color;
+ box-sizing: border-box;
+ width: 18px;
+ height: 18px;
+ margin-right: 10px;
+ top: -1px;
+ border-radius: 4px;
+ vertical-align: middle;
+
+ &.active {
+ border-color: $valid-value-color;
+ background: $valid-value-color;
+ }
+ }
+
+ &__number {
+ display: inline-block;
+ width: 36px;
+ font-weight: 700;
+ padding: 0 10px;
+ text-align: right;
+ }
+
+ &__footer {
+ padding-top: 6px;
+ padding-bottom: 5px;
+ color: $dark-text-color;
+ }
+
+ &__link {
+ display: inline;
+ background: transparent;
+ padding: 0;
+ margin: 0;
+ border: 0;
+ color: $dark-text-color;
+ text-decoration: underline;
+
+ &:hover,
+ &:focus,
+ &:active {
+ text-decoration: none;
+ }
+ }
+
+ .button {
+ height: 36px;
+ padding: 0 16px;
+ margin-right: 10px;
+ font-size: 14px;
+ }
+}
diff --git a/app/lib/activitypub/activity.rb b/app/lib/activitypub/activity.rb
index 11fa3363af..54b1756130 100644
--- a/app/lib/activitypub/activity.rb
+++ b/app/lib/activitypub/activity.rb
@@ -4,7 +4,7 @@ class ActivityPub::Activity
include JsonLdHelper
include Redisable
- SUPPORTED_TYPES = %w(Note).freeze
+ SUPPORTED_TYPES = %w(Note Question).freeze
CONVERTED_TYPES = %w(Image Video Article Page).freeze
def initialize(json, account, **options)
diff --git a/app/lib/activitypub/activity/create.rb b/app/lib/activitypub/activity/create.rb
index 0980f94bac..793e20dbe8 100644
--- a/app/lib/activitypub/activity/create.rb
+++ b/app/lib/activitypub/activity/create.rb
@@ -6,7 +6,7 @@ class ActivityPub::Activity::Create < ActivityPub::Activity
RedisLock.acquire(lock_options) do |lock|
if lock.acquired?
- return if delete_arrived_first?(object_uri)
+ return if delete_arrived_first?(object_uri) || poll_vote?
@status = find_existing_status
@@ -68,6 +68,7 @@ class ActivityPub::Activity::Create < ActivityPub::Activity
thread: replied_to_status,
conversation: conversation_from_uri(@object['conversation']),
media_attachment_ids: process_attachments.take(4).map(&:id),
+ owned_poll: process_poll,
}
end
end
@@ -209,6 +210,41 @@ class ActivityPub::Activity::Create < ActivityPub::Activity
media_attachments
end
+ def process_poll
+ return unless @object['type'] == 'Question' && (@object['anyOf'].is_a?(Array) || @object['oneOf'].is_a?(Array))
+
+ expires_at = begin
+ if @object['closed'].is_a?(String)
+ @object['closed']
+ elsif !@object['closed'].is_a?(FalseClass)
+ Time.now.utc
+ else
+ @object['endTime']
+ end
+ end
+
+ if @object['anyOf'].is_a?(Array)
+ multiple = true
+ items = @object['anyOf']
+ else
+ multiple = false
+ items = @object['oneOf']
+ end
+
+ Poll.new(
+ account: @account,
+ multiple: multiple,
+ expires_at: expires_at,
+ options: items.map { |item| item['name'].presence || item['content'] },
+ cached_tallies: items.map { |item| item.dig('replies', 'totalItems') || 0 }
+ )
+ end
+
+ def poll_vote?
+ return false if replied_to_status.nil? || replied_to_status.poll.nil? || !replied_to_status.local? || !replied_to_status.poll.options.include?(@object['name'])
+ replied_to_status.poll.votes.create!(account: @account, choice: replied_to_status.poll.options.index(@object['name']))
+ end
+
def resolve_thread(status)
return unless status.reply? && status.thread.nil? && Request.valid_url?(in_reply_to_uri)
ThreadResolveWorker.perform_async(status.id, in_reply_to_uri)
diff --git a/app/models/concerns/account_associations.rb b/app/models/concerns/account_associations.rb
index 397ec4a22a..a8ba8fef15 100644
--- a/app/models/concerns/account_associations.rb
+++ b/app/models/concerns/account_associations.rb
@@ -26,6 +26,7 @@ module AccountAssociations
# Media
has_many :media_attachments, dependent: :destroy
+ has_many :polls, dependent: :destroy
# PuSH subscriptions
has_many :subscriptions, dependent: :destroy
diff --git a/app/models/poll.rb b/app/models/poll.rb
new file mode 100644
index 0000000000..ba0b17f919
--- /dev/null
+++ b/app/models/poll.rb
@@ -0,0 +1,90 @@
+# frozen_string_literal: true
+# == Schema Information
+#
+# Table name: polls
+#
+# id :bigint(8) not null, primary key
+# account_id :bigint(8)
+# status_id :bigint(8)
+# expires_at :datetime
+# options :string default([]), not null, is an Array
+# cached_tallies :bigint(8) default([]), not null, is an Array
+# multiple :boolean default(FALSE), not null
+# hide_totals :boolean default(FALSE), not null
+# votes_count :bigint(8) default(0), not null
+# last_fetched_at :datetime
+# created_at :datetime not null
+# updated_at :datetime not null
+#
+
+class Poll < ApplicationRecord
+ include Expireable
+
+ belongs_to :account
+ belongs_to :status
+
+ has_many :votes, class_name: 'PollVote', inverse_of: :poll, dependent: :destroy
+
+ validates :options, presence: true
+ validates :expires_at, presence: true, if: :local?
+ validates_with PollValidator, if: :local?
+
+ scope :attached, -> { where.not(status_id: nil) }
+ scope :unattached, -> { where(status_id: nil) }
+
+ before_validation :prepare_votes_count
+ after_initialize :prepare_cached_tallies
+ after_commit :reset_parent_cache, on: :update
+
+ def loaded_options
+ options.map.with_index { |title, key| Option.new(self, key.to_s, title, cached_tallies[key]) }
+ end
+
+ def unloaded_options
+ options.map.with_index { |title, key| Option.new(self, key.to_s, title, nil) }
+ end
+
+ def possibly_stale?
+ remote? && last_fetched_before_expiration? && time_passed_since_last_fetch?
+ end
+
+ delegate :local?, to: :account
+
+ def remote?
+ !local?
+ end
+
+ class Option < ActiveModelSerializers::Model
+ attributes :id, :title, :votes_count, :poll
+
+ def initialize(poll, id, title, votes_count)
+ @poll = poll
+ @id = id
+ @title = title
+ @votes_count = votes_count
+ end
+ end
+
+ private
+
+ def prepare_cached_tallies
+ self.cached_tallies = options.map { 0 } if cached_tallies.empty?
+ end
+
+ def prepare_votes_count
+ self.votes_count = cached_tallies.sum unless cached_tallies.empty?
+ end
+
+ def reset_parent_cache
+ return if status_id.nil?
+ Rails.cache.delete("statuses/#{status_id}")
+ end
+
+ def last_fetched_before_expiration?
+ last_fetched_at.nil? || expires_at.nil? || last_fetched_at < expires_at
+ end
+
+ def time_passed_since_last_fetch?
+ last_fetched_at.nil? || last_fetched_at < 1.minute.ago
+ end
+end
diff --git a/app/models/poll_vote.rb b/app/models/poll_vote.rb
new file mode 100644
index 0000000000..57781d6167
--- /dev/null
+++ b/app/models/poll_vote.rb
@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+# == Schema Information
+#
+# Table name: poll_votes
+#
+# id :bigint(8) not null, primary key
+# account_id :bigint(8)
+# poll_id :bigint(8)
+# choice :integer default(0), not null
+# created_at :datetime not null
+# updated_at :datetime not null
+#
+
+class PollVote < ApplicationRecord
+ belongs_to :account
+ belongs_to :poll, inverse_of: :votes
+
+ validates :choice, presence: true
+ validates_with VoteValidator
+
+ after_create_commit :increment_counter_cache
+
+ private
+
+ def increment_counter_cache
+ poll.cached_tallies[choice] = (poll.cached_tallies[choice] || 0) + 1
+ poll.save
+ end
+end
diff --git a/app/models/status.rb b/app/models/status.rb
index 035423b402..db3c130deb 100644
--- a/app/models/status.rb
+++ b/app/models/status.rb
@@ -21,6 +21,7 @@
# account_id :bigint(8) not null
# application_id :bigint(8)
# in_reply_to_account_id :bigint(8)
+# poll_id :bigint(8)
#
class Status < ApplicationRecord
@@ -44,6 +45,7 @@ class Status < ApplicationRecord
belongs_to :account, inverse_of: :statuses
belongs_to :in_reply_to_account, foreign_key: 'in_reply_to_account_id', class_name: 'Account', optional: true
belongs_to :conversation, optional: true
+ belongs_to :poll, optional: true
belongs_to :thread, foreign_key: 'in_reply_to_id', class_name: 'Status', inverse_of: :replies, optional: true
belongs_to :reblog, foreign_key: 'reblog_of_id', class_name: 'Status', inverse_of: :reblogs, optional: true
@@ -61,6 +63,7 @@ class Status < ApplicationRecord
has_one :notification, as: :activity, dependent: :destroy
has_one :stream_entry, as: :activity, inverse_of: :status
has_one :status_stat, inverse_of: :status
+ has_one :owned_poll, class_name: 'Poll', inverse_of: :status, dependent: :destroy
validates :uri, uniqueness: true, presence: true, unless: :local?
validates :text, presence: true, unless: -> { with_media? || reblog? }
@@ -101,6 +104,7 @@ class Status < ApplicationRecord
:tags,
:preview_cards,
:stream_entry,
+ :poll,
account: :account_stat,
active_mentions: { account: :account_stat },
reblog: [
@@ -111,6 +115,7 @@ class Status < ApplicationRecord
:media_attachments,
:conversation,
:status_stat,
+ :poll,
account: :account_stat,
active_mentions: { account: :account_stat },
],
@@ -250,6 +255,8 @@ class Status < ApplicationRecord
before_validation :set_conversation
before_validation :set_local
+ before_save :set_poll_id
+
class << self
def selectable_visibilities
visibilities.keys - %w(direct limited)
@@ -438,6 +445,10 @@ class Status < ApplicationRecord
self.reblog = reblog.reblog if reblog? && reblog.reblog?
end
+ def set_poll_id
+ self.poll_id = owned_poll.id unless owned_poll.nil?
+ end
+
def set_visibility
self.visibility = (account.locked? ? :private : :public) if visibility.nil?
self.visibility = reblog.visibility if reblog?
diff --git a/app/policies/poll_policy.rb b/app/policies/poll_policy.rb
new file mode 100644
index 0000000000..0d839f2408
--- /dev/null
+++ b/app/policies/poll_policy.rb
@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class PollPolicy < ApplicationPolicy
+ def vote?
+ !current_account.blocking?(record.account) && !record.account.blocking?(current_account)
+ end
+end
diff --git a/app/serializers/activitypub/note_serializer.rb b/app/serializers/activitypub/note_serializer.rb
index 4aab993a9c..b2c92fdc15 100644
--- a/app/serializers/activitypub/note_serializer.rb
+++ b/app/serializers/activitypub/note_serializer.rb
@@ -15,12 +15,18 @@ class ActivityPub::NoteSerializer < ActiveModel::Serializer
has_one :replies, serializer: ActivityPub::CollectionSerializer, if: :local?
+ has_many :poll_loaded_options, key: :one_of, if: :poll_and_not_multiple?
+ has_many :poll_loaded_options, key: :any_of, if: :poll_and_multiple?
+
+ attribute :end_time, if: :poll_and_expires?
+ attribute :closed, if: :poll_and_expired?
+
def id
ActivityPub::TagManager.instance.uri_for(object)
end
def type
- 'Note'
+ object.poll ? 'Question' : 'Note'
end
def summary
@@ -38,6 +44,7 @@ class ActivityPub::NoteSerializer < ActiveModel::Serializer
def replies
replies = object.self_replies(5).pluck(:id, :uri)
last_id = replies.last&.first
+
ActivityPub::CollectionPresenter.new(
type: :unordered,
id: ActivityPub::TagManager.instance.replies_uri_for(object),
@@ -114,6 +121,32 @@ class ActivityPub::NoteSerializer < ActiveModel::Serializer
object.account.local?
end
+ def poll_loaded_options
+ object.poll.loaded_options
+ end
+
+ def poll_and_multiple?
+ object.poll&.multiple?
+ end
+
+ def poll_and_not_multiple?
+ object.poll && !object.poll.multiple?
+ end
+
+ def closed
+ object.poll.expires_at.iso8601
+ end
+
+ alias end_time closed
+
+ def poll_and_expires?
+ object.poll&.expires_at&.present?
+ end
+
+ def poll_and_expired?
+ object.poll&.expired?
+ end
+
class MediaAttachmentSerializer < ActiveModel::Serializer
include RoutingHelper
@@ -181,4 +214,34 @@ class ActivityPub::NoteSerializer < ActiveModel::Serializer
class CustomEmojiSerializer < ActivityPub::EmojiSerializer
end
+
+ class OptionSerializer < ActiveModel::Serializer
+ class RepliesSerializer < ActiveModel::Serializer
+ attributes :type, :total_items
+
+ def type
+ 'Collection'
+ end
+
+ def total_items
+ object.votes_count
+ end
+ end
+
+ attributes :type, :name
+
+ has_one :replies, serializer: ActivityPub::NoteSerializer::OptionSerializer::RepliesSerializer
+
+ def type
+ 'Note'
+ end
+
+ def name
+ object.title
+ end
+
+ def replies
+ object
+ end
+ end
end
diff --git a/app/serializers/activitypub/vote_serializer.rb b/app/serializers/activitypub/vote_serializer.rb
new file mode 100644
index 0000000000..5489fbcd3e
--- /dev/null
+++ b/app/serializers/activitypub/vote_serializer.rb
@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+class ActivityPub::VoteSerializer < ActiveModel::Serializer
+ class NoteSerializer < ActiveModel::Serializer
+ attributes :id, :type, :name, :attributed_to,
+ :in_reply_to, :to
+
+ def id
+ nil
+ end
+
+ def type
+ 'Note'
+ end
+
+ def name
+ object.poll.options[object.choice.to_i]
+ end
+
+ def attributed_to
+ ActivityPub::TagManager.instance.uri_for(object.account)
+ end
+
+ def to
+ ActivityPub::TagManager.instance.uri_for(object.poll.account)
+ end
+ end
+
+ attributes :id, :type, :actor, :to
+
+ has_one :object, serializer: ActivityPub::VoteSerializer::NoteSerializer
+
+ def id
+ nil
+ end
+
+ def type
+ 'Create'
+ end
+
+ def actor
+ ActivityPub::TagManager.instance.uri_for(object.account)
+ end
+
+ def to
+ ActivityPub::TagManager.instance.uri_for(object.poll.account)
+ end
+end
diff --git a/app/serializers/rest/poll_serializer.rb b/app/serializers/rest/poll_serializer.rb
new file mode 100644
index 0000000000..b02e8ca934
--- /dev/null
+++ b/app/serializers/rest/poll_serializer.rb
@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+class REST::PollSerializer < ActiveModel::Serializer
+ attributes :id, :expires_at, :expired,
+ :multiple, :votes_count
+
+ has_many :dynamic_options, key: :options
+
+ attribute :voted, if: :current_user?
+
+ def id
+ object.id.to_s
+ end
+
+ def dynamic_options
+ if !object.expired? && object.hide_totals?
+ object.unloaded_options
+ else
+ object.loaded_options
+ end
+ end
+
+ def expired
+ object.expired?
+ end
+
+ def voted
+ object.votes.where(account: current_user.account).exists?
+ end
+
+ def current_user?
+ !current_user.nil?
+ end
+
+ class OptionSerializer < ActiveModel::Serializer
+ attributes :title, :votes_count
+ end
+end
diff --git a/app/serializers/rest/status_serializer.rb b/app/serializers/rest/status_serializer.rb
index 66e19be560..30edf397bd 100644
--- a/app/serializers/rest/status_serializer.rb
+++ b/app/serializers/rest/status_serializer.rb
@@ -21,6 +21,7 @@ class REST::StatusSerializer < ActiveModel::Serializer
has_many :emojis, serializer: REST::CustomEmojiSerializer
has_one :preview_card, key: :card, serializer: REST::PreviewCardSerializer
+ has_one :poll, serializer: REST::PollSerializer
def id
object.id.to_s
diff --git a/app/services/activitypub/fetch_remote_poll_service.rb b/app/services/activitypub/fetch_remote_poll_service.rb
new file mode 100644
index 0000000000..6f0ac5624f
--- /dev/null
+++ b/app/services/activitypub/fetch_remote_poll_service.rb
@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+class ActivityPub::FetchRemotePollService < BaseService
+ include JsonLdHelper
+
+ def call(poll, on_behalf_of = nil)
+ @json = fetch_resource(poll.status.uri, true, on_behalf_of)
+
+ return unless supported_context? && expected_type?
+
+ expires_at = begin
+ if @json['closed'].is_a?(String)
+ @json['closed']
+ elsif !@json['closed'].is_a?(FalseClass)
+ Time.now.utc
+ else
+ @json['endTime']
+ end
+ end
+
+ items = begin
+ if @json['anyOf'].is_a?(Array)
+ @json['anyOf']
+ else
+ @json['oneOf']
+ end
+ end
+
+ latest_options = items.map { |item| item['name'].presence || item['content'] }
+
+ # If for some reasons the options were changed, it invalidates all previous
+ # votes, so we need to remove them
+ poll.votes.delete_all if latest_options != poll.options
+
+ poll.update!(
+ expires_at: expires_at,
+ options: latest_options,
+ cached_tallies: items.map { |item| item.dig('replies', 'totalItems') || 0 }
+ )
+ end
+
+ private
+
+ def supported_context?
+ super(@json)
+ end
+
+ def expected_type?
+ equals_or_includes_any?(@json['type'], 'Question')
+ end
+end
diff --git a/app/services/post_status_service.rb b/app/services/post_status_service.rb
index 686b10c581..aed6806721 100644
--- a/app/services/post_status_service.rb
+++ b/app/services/post_status_service.rb
@@ -15,6 +15,7 @@ class PostStatusService < BaseService
# @option [String] :spoiler_text
# @option [String] :language
# @option [String] :scheduled_at
+ # @option [Hash] :poll Optional poll to attach
# @option [Enumerable] :media_ids Optional array of media IDs to attach
# @option [Doorkeeper::Application] :application
# @option [String] :idempotency Optional idempotency key
@@ -28,6 +29,7 @@ class PostStatusService < BaseService
return idempotency_duplicate if idempotency_given? && idempotency_duplicate?
validate_media!
+ validate_poll!
preprocess_attributes!
if scheduled?
@@ -93,13 +95,19 @@ class PostStatusService < BaseService
def validate_media!
return if @options[:media_ids].blank? || !@options[:media_ids].is_a?(Enumerable)
- raise Mastodon::ValidationError, I18n.t('media_attachments.validations.too_many') if @options[:media_ids].size > 4
+ raise Mastodon::ValidationError, I18n.t('media_attachments.validations.too_many') if @options[:media_ids].size > 4 || @options[:poll_id].present?
@media = @account.media_attachments.where(status_id: nil).where(id: @options[:media_ids].take(4).map(&:to_i))
raise Mastodon::ValidationError, I18n.t('media_attachments.validations.images_and_video') if @media.size > 1 && @media.find(&:video?)
end
+ def validate_poll!
+ return if @options[:poll].blank?
+
+ @poll = @account.polls.new(@options[:poll])
+ end
+
def language_from_option(str)
ISO_639.find(str)&.alpha2
end
@@ -152,6 +160,7 @@ class PostStatusService < BaseService
text: @text,
media_attachments: @media || [],
thread: @in_reply_to,
+ owned_poll: @poll,
sensitive: (@options[:sensitive].nil? ? @account.user&.setting_default_sensitive : @options[:sensitive]) || @options[:spoiler_text].present?,
spoiler_text: @options[:spoiler_text] || '',
visibility: @visibility,
diff --git a/app/services/vote_service.rb b/app/services/vote_service.rb
new file mode 100644
index 0000000000..8bab2810ea
--- /dev/null
+++ b/app/services/vote_service.rb
@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+class VoteService < BaseService
+ include Authorization
+
+ def call(account, poll, choices)
+ authorize_with account, poll, :vote?
+
+ @account = account
+ @poll = poll
+ @choices = choices
+ @votes = []
+
+ ApplicationRecord.transaction do
+ @choices.each do |choice|
+ @votes << @poll.votes.create!(account: @account, choice: choice)
+ end
+ end
+
+ return if @poll.account.local?
+
+ @votes.each do |vote|
+ ActivityPub::DeliveryWorker.perform_async(
+ build_json(vote),
+ @account.id,
+ @poll.account.inbox_url
+ )
+ end
+ end
+
+ private
+
+ def build_json(vote)
+ ActiveModelSerializers::SerializableResource.new(
+ vote,
+ serializer: ActivityPub::VoteSerializer,
+ adapter: ActivityPub::Adapter
+ ).to_json
+ end
+end
diff --git a/app/validators/poll_validator.rb b/app/validators/poll_validator.rb
new file mode 100644
index 0000000000..a1c4f68515
--- /dev/null
+++ b/app/validators/poll_validator.rb
@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+class PollValidator < ActiveModel::Validator
+ MAX_OPTIONS = 4
+ MAX_OPTION_CHARS = 25
+ MAX_EXPIRATION = 7.days.freeze
+ MIN_EXPIRATION = 1.day.freeze
+
+ def validate(poll)
+ current_time = Time.now.utc
+
+ poll.errors.add(:options, I18n.t('polls.errors.too_few_options')) unless poll.options.size > 1
+ poll.errors.add(:options, I18n.t('polls.errors.too_many_options', max: MAX_OPTIONS)) if poll.options.size > MAX_OPTIONS
+ poll.errors.add(:options, I18n.t('polls.errors.over_character_limit', max: MAX_OPTION_CHARS)) if poll.options.any? { |option| option.mb_chars.grapheme_length > MAX_OPTION_CHARS }
+ poll.errors.add(:options, I18n.t('polls.errors.duplicate_options')) unless poll.options.uniq.size == poll.options.size
+ poll.errors.add(:expires_at, I18n.t('polls.errors.duration_too_long')) if poll.expires_at.nil? || poll.expires_at - current_time >= MAX_EXPIRATION
+ poll.errors.add(:expires_at, I18n.t('polls.errors.duration_too_short')) if poll.expires_at.present? && poll.expires_at - current_time <= MIN_EXPIRATION
+ end
+end
diff --git a/app/validators/vote_validator.rb b/app/validators/vote_validator.rb
new file mode 100644
index 0000000000..e2a68d1f38
--- /dev/null
+++ b/app/validators/vote_validator.rb
@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+class VoteValidator < ActiveModel::Validator
+ def validate(vote)
+ vote.errors.add(:base, I18n.t('polls.errors.expired')) if vote.poll.expired?
+
+ if vote.poll.multiple? && vote.poll.votes.where(account: vote.account, choice: vote.choice).exists?
+ vote.errors.add(:base, I18n.t('polls.errors.already_voted'))
+ elsif vote.poll.votes.where(account: vote.account).exists?
+ vote.errors.add(:base, I18n.t('polls.errors.already_voted'))
+ end
+ end
+end
diff --git a/app/views/stream_entries/_detailed_status.html.haml b/app/views/stream_entries/_detailed_status.html.haml
index e123d657fa..b9327a546c 100644
--- a/app/views/stream_entries/_detailed_status.html.haml
+++ b/app/views/stream_entries/_detailed_status.html.haml
@@ -22,7 +22,9 @@
%a.status__content__spoiler-link{ href: '#' }= t('statuses.show_more')
.e-content{ lang: status.language, style: "display: #{!current_account&.user&.setting_expand_spoilers && status.spoiler_text? ? 'none' : 'block'}; direction: #{rtl_status?(status) ? 'rtl' : 'ltr'}" }= Formatter.instance.format(status, custom_emojify: true, autoplay: autoplay)
- - if !status.media_attachments.empty?
+ - if status.poll
+ = react_component :poll, disabled: true, poll: ActiveModelSerializers::SerializableResource.new(status.poll, serializer: REST::PollSerializer, scope: current_user, scope_name: :current_user).as_json
+ - elsif !status.media_attachments.empty?
- if status.media_attachments.first.video?
- video = status.media_attachments.first
= react_component :video, src: video.file.url(:original), preview: video.file.url(:small), sensitive: !current_account&.user&.show_all_media? && status.sensitive? || current_account&.user&.hide_all_media?, width: 670, height: 380, detailed: true, inline: true, alt: video.description do
diff --git a/app/views/stream_entries/_simple_status.html.haml b/app/views/stream_entries/_simple_status.html.haml
index b0b6e80c89..a000c02f4c 100644
--- a/app/views/stream_entries/_simple_status.html.haml
+++ b/app/views/stream_entries/_simple_status.html.haml
@@ -26,7 +26,9 @@
%a.status__content__spoiler-link{ href: '#' }= t('statuses.show_more')
.e-content{ lang: status.language, style: "display: #{!current_account&.user&.setting_expand_spoilers && status.spoiler_text? ? 'none' : 'block'}; direction: #{rtl_status?(status) ? 'rtl' : 'ltr'}" }= Formatter.instance.format(status, custom_emojify: true, autoplay: autoplay)
- - if !status.media_attachments.empty?
+ - if status.poll
+ = react_component :poll, disabled: true, poll: ActiveModelSerializers::SerializableResource.new(status.poll, serializer: REST::PollSerializer, scope: current_user, scope_name: :current_user).as_json
+ - elsif !status.media_attachments.empty?
- if status.media_attachments.first.video?
- video = status.media_attachments.first
= react_component :video, src: video.file.url(:original), preview: video.file.url(:small), sensitive: !current_account&.user&.show_all_media? && status.sensitive? || current_account&.user&.hide_all_media?, width: 610, height: 343, inline: true, alt: video.description do
diff --git a/config/locales/en.yml b/config/locales/en.yml
index 7363a7457f..b1f6166b4b 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -734,6 +734,16 @@ en:
older: Older
prev: Prev
truncate: "…"
+ polls:
+ errors:
+ already_voted: You have already voted on this poll
+ duplicate_options: contain duplicate items
+ duration_too_long: is too far into the future
+ duration_too_short: is too soon
+ expired: The poll has already ended
+ over_character_limit: cannot be longer than %{MAX} characters each
+ too_few_options: must have more than one item
+ too_many_options: can't contain more than %{MAX} items
preferences:
languages: Languages
other: Other
diff --git a/config/routes.rb b/config/routes.rb
index 9a83d0f882..ac10f9fba8 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -362,6 +362,10 @@ Rails.application.routes.draw do
resource :accounts, only: [:show, :create, :destroy], controller: 'lists/accounts'
end
+ resources :polls, only: [:create, :show] do
+ resources :votes, only: :create, controller: 'polls/votes'
+ end
+
namespace :push do
resource :subscription, only: [:create, :show, :update, :destroy]
end
diff --git a/db/migrate/20190225031541_create_polls.rb b/db/migrate/20190225031541_create_polls.rb
new file mode 100644
index 0000000000..ea9ad0425f
--- /dev/null
+++ b/db/migrate/20190225031541_create_polls.rb
@@ -0,0 +1,17 @@
+class CreatePolls < ActiveRecord::Migration[5.2]
+ def change
+ create_table :polls do |t|
+ t.belongs_to :account, foreign_key: { on_delete: :cascade }
+ t.belongs_to :status, foreign_key: { on_delete: :cascade }
+ t.datetime :expires_at
+ t.string :options, null: false, array: true, default: []
+ t.bigint :cached_tallies, null: false, array: true, default: []
+ t.boolean :multiple, null: false, default: false
+ t.boolean :hide_totals, null: false, default: false
+ t.bigint :votes_count, null: false, default: 0
+ t.datetime :last_fetched_at
+
+ t.timestamps
+ end
+ end
+end
diff --git a/db/migrate/20190225031625_create_poll_votes.rb b/db/migrate/20190225031625_create_poll_votes.rb
new file mode 100644
index 0000000000..a0849d3a55
--- /dev/null
+++ b/db/migrate/20190225031625_create_poll_votes.rb
@@ -0,0 +1,11 @@
+class CreatePollVotes < ActiveRecord::Migration[5.2]
+ def change
+ create_table :poll_votes do |t|
+ t.belongs_to :account, foreign_key: { on_delete: :cascade }
+ t.belongs_to :poll, foreign_key: { on_delete: :cascade }
+ t.integer :choice, null: false, default: 0
+
+ t.timestamps
+ end
+ end
+end
diff --git a/db/migrate/20190226003449_add_poll_id_to_statuses.rb b/db/migrate/20190226003449_add_poll_id_to_statuses.rb
new file mode 100644
index 0000000000..692e8f814f
--- /dev/null
+++ b/db/migrate/20190226003449_add_poll_id_to_statuses.rb
@@ -0,0 +1,5 @@
+class AddPollIdToStatuses < ActiveRecord::Migration[5.2]
+ def change
+ add_column :statuses, :poll_id, :bigint
+ end
+end
diff --git a/db/schema.rb b/db/schema.rb
index e9fb358f80..d5d516e066 100644
--- a/db/schema.rb
+++ b/db/schema.rb
@@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.
-ActiveRecord::Schema.define(version: 2019_02_03_180359) do
+ActiveRecord::Schema.define(version: 2019_02_26_003449) do
# These are extensions that must be enabled in order to support this database
enable_extension "plpgsql"
@@ -441,6 +441,32 @@ ActiveRecord::Schema.define(version: 2019_02_03_180359) do
t.index ["database", "captured_at"], name: "index_pghero_space_stats_on_database_and_captured_at"
end
+ create_table "poll_votes", force: :cascade do |t|
+ t.bigint "account_id"
+ t.bigint "poll_id"
+ t.integer "choice", default: 0, null: false
+ t.datetime "created_at", null: false
+ t.datetime "updated_at", null: false
+ t.index ["account_id"], name: "index_poll_votes_on_account_id"
+ t.index ["poll_id"], name: "index_poll_votes_on_poll_id"
+ end
+
+ create_table "polls", force: :cascade do |t|
+ t.bigint "account_id"
+ t.bigint "status_id"
+ t.datetime "expires_at"
+ t.string "options", default: [], null: false, array: true
+ t.bigint "cached_tallies", default: [], null: false, array: true
+ t.boolean "multiple", default: false, null: false
+ t.boolean "hide_totals", default: false, null: false
+ t.bigint "votes_count", default: 0, null: false
+ t.datetime "last_fetched_at"
+ t.datetime "created_at", null: false
+ t.datetime "updated_at", null: false
+ t.index ["account_id"], name: "index_polls_on_account_id"
+ t.index ["status_id"], name: "index_polls_on_status_id"
+ end
+
create_table "preview_cards", force: :cascade do |t|
t.string "url", default: "", null: false
t.string "title", default: "", null: false
@@ -581,6 +607,7 @@ ActiveRecord::Schema.define(version: 2019_02_03_180359) do
t.bigint "account_id", null: false
t.bigint "application_id"
t.bigint "in_reply_to_account_id"
+ t.bigint "poll_id"
t.index ["account_id", "id", "visibility", "updated_at"], name: "index_statuses_20180106", order: { id: :desc }
t.index ["in_reply_to_account_id"], name: "index_statuses_on_in_reply_to_account_id"
t.index ["in_reply_to_id"], name: "index_statuses_on_in_reply_to_id"
@@ -746,6 +773,10 @@ ActiveRecord::Schema.define(version: 2019_02_03_180359) do
add_foreign_key "oauth_access_tokens", "oauth_applications", column: "application_id", name: "fk_f5fc4c1ee3", on_delete: :cascade
add_foreign_key "oauth_access_tokens", "users", column: "resource_owner_id", name: "fk_e84df68546", on_delete: :cascade
add_foreign_key "oauth_applications", "users", column: "owner_id", name: "fk_b0988c7c0a", on_delete: :cascade
+ add_foreign_key "poll_votes", "accounts", on_delete: :cascade
+ add_foreign_key "poll_votes", "polls", on_delete: :cascade
+ add_foreign_key "polls", "accounts", on_delete: :cascade
+ add_foreign_key "polls", "statuses", on_delete: :cascade
add_foreign_key "report_notes", "accounts", on_delete: :cascade
add_foreign_key "report_notes", "reports", on_delete: :cascade
add_foreign_key "reports", "accounts", column: "action_taken_by_account_id", name: "fk_bca45b75fd", on_delete: :nullify
diff --git a/spec/controllers/api/v1/filter_controller_spec.rb b/spec/controllers/api/v1/filters_controller_spec.rb
similarity index 100%
rename from spec/controllers/api/v1/filter_controller_spec.rb
rename to spec/controllers/api/v1/filters_controller_spec.rb
diff --git a/spec/controllers/api/v1/polls/votes_controller_spec.rb b/spec/controllers/api/v1/polls/votes_controller_spec.rb
new file mode 100644
index 0000000000..0ee3aa040c
--- /dev/null
+++ b/spec/controllers/api/v1/polls/votes_controller_spec.rb
@@ -0,0 +1,34 @@
+require 'rails_helper'
+
+RSpec.describe Api::V1::Polls::VotesController, type: :controller do
+ render_views
+
+ let(:user) { Fabricate(:user, account: Fabricate(:account, username: 'alice')) }
+ let(:scopes) { 'write:statuses' }
+ let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: scopes) }
+
+ before { allow(controller).to receive(:doorkeeper_token) { token } }
+
+ describe 'POST #create' do
+ let(:poll) { Fabricate(:poll) }
+
+ before do
+ post :create, params: { poll_id: poll.id, choices: %w(1) }
+ end
+
+ it 'returns http success' do
+ expect(response).to have_http_status(200)
+ end
+
+ it 'creates a vote' do
+ vote = poll.votes.where(account: user.account).first
+
+ expect(vote).to_not be_nil
+ expect(vote.choice).to eq 1
+ end
+
+ it 'updates poll tallies' do
+ expect(poll.reload.cached_tallies).to eq [0, 1]
+ end
+ end
+end
diff --git a/spec/controllers/api/v1/polls_controller_spec.rb b/spec/controllers/api/v1/polls_controller_spec.rb
new file mode 100644
index 0000000000..2b8d5f3ef5
--- /dev/null
+++ b/spec/controllers/api/v1/polls_controller_spec.rb
@@ -0,0 +1,23 @@
+require 'rails_helper'
+
+RSpec.describe Api::V1::PollsController, type: :controller do
+ render_views
+
+ let(:user) { Fabricate(:user, account: Fabricate(:account, username: 'alice')) }
+ let(:scopes) { 'read:statuses' }
+ let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: scopes) }
+
+ before { allow(controller).to receive(:doorkeeper_token) { token } }
+
+ describe 'GET #show' do
+ let(:poll) { Fabricate(:poll) }
+
+ before do
+ get :show, params: { id: poll.id }
+ end
+
+ it 'returns http success' do
+ expect(response).to have_http_status(200)
+ end
+ end
+end
diff --git a/spec/fabricators/poll_fabricator.rb b/spec/fabricators/poll_fabricator.rb
new file mode 100644
index 0000000000..746610f7c6
--- /dev/null
+++ b/spec/fabricators/poll_fabricator.rb
@@ -0,0 +1,8 @@
+Fabricator(:poll) do
+ account
+ status
+ expires_at { 7.days.from_now }
+ options %w(Foo Bar)
+ multiple false
+ hide_totals false
+end
diff --git a/spec/fabricators/poll_vote_fabricator.rb b/spec/fabricators/poll_vote_fabricator.rb
new file mode 100644
index 0000000000..51f9b006e6
--- /dev/null
+++ b/spec/fabricators/poll_vote_fabricator.rb
@@ -0,0 +1,5 @@
+Fabricator(:poll_vote) do
+ account
+ poll
+ choice 0
+end
diff --git a/spec/models/poll_spec.rb b/spec/models/poll_spec.rb
new file mode 100644
index 0000000000..666f8ca683
--- /dev/null
+++ b/spec/models/poll_spec.rb
@@ -0,0 +1,5 @@
+require 'rails_helper'
+
+RSpec.describe Poll, type: :model do
+ pending "add some examples to (or delete) #{__FILE__}"
+end
diff --git a/spec/models/poll_vote_spec.rb b/spec/models/poll_vote_spec.rb
new file mode 100644
index 0000000000..354afd5350
--- /dev/null
+++ b/spec/models/poll_vote_spec.rb
@@ -0,0 +1,5 @@
+require 'rails_helper'
+
+RSpec.describe PollVote, type: :model do
+ pending "add some examples to (or delete) #{__FILE__}"
+end