astrid
/
mastodon
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve error handling in streaming/index.js (#5968) 

On an unhandled worker exception, we should log the exception
and exit with nonzero status, instead of letting workers
silently fail and restarting them in an endless loop.

Note: we previously tried to handle the `'error'` signal.
That's not a signal Node fires; my patch traps `'uncaughtException'`,
which is what the code was _trying_ to do.
pull/5996/head
erin 2017-12-12 13:19:33 -06:00 committed by Eugen Rochko
parent 0c8b1eb577
commit c986218c3a
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
streaming/index.js
View File

@ -563,12 +563,14 @@ const startWorker = (workerId) => {
const onError = (err) => { const onError = (err) => {
log.error(err); log.error(err);
server.close();
process.exit(0);
}; };
process.on('SIGINT', onExit); process.on('SIGINT', onExit);
process.on('SIGTERM', onExit); process.on('SIGTERM', onExit);
process.on('exit', onExit); process.on('exit', onExit);
process.on('error', onError); process.on('uncaughtException', onError);
}; };
throng({ throng({