From 38bb650f1229459d5f9bfdc10863bd5821d55626 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Mon, 27 Jan 2025 05:18:38 +0000 Subject: [PATCH] util/nvmutil: clean up readonly check on writeGbe Signed-off-by: Leah Rowe --- util/nvmutil/nvmutil.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/util/nvmutil/nvmutil.c b/util/nvmutil/nvmutil.c index b88375a..4eecebe 100644 --- a/util/nvmutil/nvmutil.c +++ b/util/nvmutil/nvmutil.c @@ -435,13 +435,10 @@ goodChecksum(int partnum) void writeGbe(void) { - if ((flags == O_RDONLY)) - return; - ssize_t tnw = 0; /* total bytes written */ for (int p = 0; p < 2; p++) { - if ((!nvmPartChanged[p])) + if ((!nvmPartChanged[p]) || (flags == O_RDONLY)) continue; swap(p); /* swap bytes on big-endian host CPUs */ @@ -455,7 +452,7 @@ writeGbe(void) tnw += nf; } - if ((!tnw) && !(nvmPartChanged[0] || nvmPartChanged[1])) + if ((!tnw) && (flags != O_RDONLY)) fprintf(stderr, "No changes needed on file '%s'\n", filename); else if (tnw) printf("%ld bytes written to file '%s'\n", tnw, filename);