canoeboot
/
cbmk
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

build/roms: don't rely on x in handle_target 

x is part of the for loop in main() and may or not
still be available from handle_target, depending on
your implementation of sh, but this should not be assumed

do it properly

Signed-off-by: Leah Rowe <leah@libreboot.org>
audit2-merge1
Leah Rowe 2024-05-05 05:28:06 +01:00 committed by Leah Rowe
parent 1c84d0fc9d
commit 6bdbb70dbc
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
script/build/roms
View File

@ -62,7 +62,7 @@ main()
$err "Cannot generate list of boards for building" $err "Cannot generate list of boards for building"
for x in ${boards}; do for x in ${boards}; do
handle_target handle_target "$x"
done done
[ "$listboards" = "y" ] && return 0 [ "$listboards" = "y" ] && return 0
@ -85,7 +85,7 @@ handle_target()
{ {
eval "$(setvars "n" ${pv}) $(setvars "" ${v})" eval "$(setvars "n" ${pv}) $(setvars "" ${v})"
grub_background="background1280x800.png" grub_background="background1280x800.png"
board="${x}" board="$1"
status="unknown" status="unknown"
configure_target configure_target