roms: don't insert timeout.cfg

this is bloat, because it's something the user can already
do at runtime configuration anyway.

set it to a reasonable default of 8 seconds instead of 5,
and don't honour the timeout variable in target.cfg.

this will be documented in the next release.

Signed-off-by: Leah Rowe <leah@libreboot.org>

config/coreboot/g43t_am3/target.cfg

@@ -2,5 +2,4 @@ tree="default"
 xarch="i386-elf"
 payload_seabios="y"
 payload_memtest="y"
-grub_timeout=10
 grubtree="nvme"

config/coreboot/g43t_am3_16mb/target.cfg

@@ -2,6 +2,5 @@ tree="default"
 xarch="i386-elf"
 payload_seabios="y"
 payload_memtest="y"
-grub_timeout=10
 release="n"
 grubtree="nvme"

config/coreboot/ga_g41m_es2l/target.cfg

@@ -2,5 +2,4 @@ tree="default"
 xarch="i386-elf"
 payload_seabios="y"
 payload_memtest="y"
-grub_timeout=10
 grubtree="nvme"

config/coreboot/kcma_d8_rdimm_16mb/target.cfg

@@ -4,6 +4,5 @@ payload_seabios="y"
 payload_seabios_withgrub="y"
 payload_memtest="y"
 xlang="c"
-grub_timeout=10
 grub_scan_disk="nvme ahci"
 grubtree="nvme"

config/coreboot/kcma_d8_udimm_2mb/target.cfg

@@ -5,6 +5,5 @@ payload_seabios="y"
 payload_seabios_withgrub="y"
 payload_memtest="y"
 xlang="c"
-grub_timeout=10
 grub_scan_disk="nvme ahci"
 grubtree="nvme"

config/coreboot/kfsn4_dre_1mb/target.cfg

@@ -3,4 +3,3 @@ xarch="i386-elf"
 payload_seabios="y"
 payload_memtest="y"
 xlang="c"
-grub_timeout=10

config/coreboot/kfsn4_dre_2mb/target.cfg

@@ -4,4 +4,3 @@ payload_seabios="y"
 payload_seabios_withgrub="y"
 payload_memtest="y"
 xlang="c"
-grub_timeout=10

config/coreboot/kgpe_d16_rdimm_16mb/target.cfg

@@ -4,6 +4,5 @@ payload_seabios="y"
 payload_seabios_withgrub="y"
 payload_memtest="y"
 xlang="c"
-grub_timeout=10
 grub_scan_disk="nvme ahci"
 grubtree="nvme"

config/coreboot/kgpe_d16_rdimm_2mb/target.cfg

@@ -4,6 +4,5 @@ payload_seabios="y"
 payload_seabios_withgrub="y"
 payload_memtest="y"
 xlang="c"
-grub_timeout=10
 grub_scan_disk="nvme ahci"
 grubtree="nvme"

config/coreboot/kgpe_d16_udimm_16mb/target.cfg

@@ -5,6 +5,5 @@ payload_seabios="y"
 payload_seabios_withgrub="y"
 payload_memtest="y"
 xlang="c"
-grub_timeout=10
 grub_scan_disk="nvme ahci"
 grubtree="nvme"

config/coreboot/kgpe_d16_udimm_2mb/target.cfg

@@ -5,6 +5,5 @@ payload_seabios="y"
 payload_seabios_withgrub="y"
 payload_memtest="y"
 xlang="c"
-grub_timeout=10
 grub_scan_disk="nvme ahci"
 grubtree="nvme"

config/grub/default/config/payload

@@ -53,7 +53,7 @@ set default="0"
 if [ -f (cbfsdisk)/timeout.cfg ]; then
 	source (cbfsdisk)/timeout.cfg
 else	
-	set timeout=5
+	set timeout=8
 fi
 set grub_scan_disk="ahci ata"
 if [ -f (cbfsdisk)/scan.cfg ]; then

config/grub/nvme/config/payload

@@ -53,7 +53,7 @@ set default="0"
 if [ -f (cbfsdisk)/timeout.cfg ]; then
 	source (cbfsdisk)/timeout.cfg
 else	
-	set timeout=5
+	set timeout=8
 fi
 set grub_scan_disk="nvme ahci ata"
 if [ -f (cbfsdisk)/scan.cfg ]; then

config/grub/xhci/config/payload

@@ -54,7 +54,7 @@ set default="0"
 if [ -f (cbfsdisk)/timeout.cfg ]; then
 	source (cbfsdisk)/timeout.cfg
 else	
-	set timeout=5
+	set timeout=8
 fi
 set grub_scan_disk="nvme ahci ata"
 if [ -f (cbfsdisk)/scan.cfg ]; then

script/roms

@@ -17,7 +17,6 @@ rp2040x="$rp2040src/build/pico_serprog.uf2"
 picosdk="src/pico-sdk"
 stm32src="src/stm32-vserprog"
 stm32x="$stm32src/stm32-vserprog.hex"
-tmpcfg="$tmpdir/tmpcfg"
 
 # Disable all payloads by default.
 # target.cfg files have to specifically enable [a] payload(s)
@@ -217,12 +216,9 @@ build_grub_roms()
 	# we only need insert grub.elf once, for each coreboot config:
 	cbfs "$tmprom" "$grubelf" "$grub_cbfs"
 
-	printf "set grub_scan_disk=\"%s\"\n" "$grub_scan_disk" > "$tmpcfg" || \
+	printf "set grub_scan_disk=\"%s\"\n" "$grub_scan_disk" \
-	    $err "set grub_scan_disk, $grub_scan_disk, $tmpcfg"
+	    > "$tmpdir/tmpcfg" || $err "set grub_scan_disk, $grub_scan_disk"
-	cbfs "$tmprom" "$tmpcfg" scan.cfg raw
+	cbfs "$tmprom" "$tmpdir/tmpcfg" scan.cfg raw
-
-	printf "set timeout=%s\n" "$grub_timeout" > "$tmpcfg" || $err "!time"
-	[ -z "$grub_timeout" ] || cbfs "$tmprom" "$tmpcfg" timeout.cfg raw
 
 	newrom="$romdir/${payload1}_${board}_${initmode}_$displaymode.rom"
 	[ "$initmode" = "normal" ] && newrom="$romdir/${payload1}_" \