From d0a949d00b1af5d0e2dc52aef84e56b7283d0548 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Mon, 24 Jun 2024 17:28:25 +0100 Subject: [PATCH] roms: build coreboot early to avoid duplicate work we're building it per coreboot configuration file, rather than per-target; the latter is more appropriate, and saves on compilation time. do it per-target.cfg, not per coreboot configuration. this works because the trees script compiles all images per target, for each given coreboot configuration within that target, e.g. libgfxinit _corebootfb and _txtmode. Signed-off-by: Leah Rowe --- script/roms | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/script/roms b/script/roms index d6e682e..7cfba29 100755 --- a/script/roms +++ b/script/roms @@ -91,6 +91,7 @@ configure_target() # Override the above defaults using target.cfg eval `setcfg "$targetdir/target.cfg"` + x_ ./update trees -b coreboot $board [ -z "$tree" ] && $err "$board: tree not defined" [ "$xbmk_release" = "y" ] && [ "$release" = "n" ] && return 1 @@ -135,8 +136,6 @@ build_board() build_roms() { - x_ ./update trees -b coreboot $board - cbuild="$cbelfdir/$board/${initmode}_$displaymode" [ "$initmode" = "normal" ] && cbuild="${cbuild%"_$displaymode"}" x_ cp "$cbuild/coreboot.rom" "$tmprom"