canoeboot
/
cbmk
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

option.sh: don't return 1 in mkrom_tarball 

one of the calling functions relies on the return value
to be always 0, so these error conditions in mkrom_tarball
have been altered to cause an *exit* (non-zero) instead.

in practise, the commands in question were printf commands
run after tho directory they output to had been created,
so write access would probably not be an issue.

nonetheless, technically correct is the best kind of correct.

Signed-off-by: Leah Rowe <leah@libreboot.org>
audit2-merge1
Leah Rowe 2024-05-19 06:51:20 +01:00 committed by Leah Rowe
parent ae8637b620
commit ddcb793bd2
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/option.sh
View File

@ -153,9 +153,9 @@ git_err()
mkrom_tarball()
{
printf "%s\n" "${version}" > "${1}/version" || return 1
printf "%s\n" "${versiondate}" > "${1}/versiondate" || return 1
printf "%s\n" "${projectname}" > "${1}/projectname" || return 1
printf "%s\n" "${version}" > "${1}/version" || $err "$1 !version"
printf "%s\n" "${versiondate}" > "${1}/versiondate" || $err "$1 !vdate"
printf "%s\n" "${projectname}" > "${1}/projectname" || $err "$1 !pname"
mktarball "$1" "${1%/*}/${relname}_${1##*/}.tar.xz"
x_ rm -Rf "$1"