From e8b7e74db5e5c06444f70f6c4ebf0584f111cd5d Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Tue, 25 Jun 2024 09:54:22 +0100 Subject: [PATCH] roms: build coreboot *after* checking variables otherwise, release=n is ignored and an image is built in the elf/ directory, even if it's still skipped for bin/ avoid doing unnecessary work per-release by checking the variables before building coreboot via script/trees Signed-off-by: Leah Rowe --- script/roms | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/script/roms b/script/roms index 6bc7b38..bc77a49 100755 --- a/script/roms +++ b/script/roms @@ -93,12 +93,13 @@ configure_target() # Override the above defaults using target.cfg eval `setcfg "$targetdir/target.cfg"` - x_ ./update trees -b coreboot $board [ -z "$tree" ] && $err "$board: tree not defined" [ "$XBMK_RELEASE" = "y" ] && [ "$release" = "n" ] && return 1 [ "$board" = "$tree" ] && return 1 + x_ ./update trees -b coreboot $board + cbdir="src/coreboot/$tree" cbfstool="elf/cbfstool/$tree/cbfstool" [ -f "$cbfstool" ] || x_ ./update trees -b coreboot utils $tree