From 72a2762b7b7cadac1dfd628a908af17fb907df9c Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Fri, 3 May 2024 06:33:05 +0100 Subject: [PATCH 1/1] never download blobs even if USE_BLOBS=y With this and the existing never-add-microcode patch, I can re-use lbmk coreboot configs without modifying them. I already don't disable microcode in those configs when porting them to canoeboot, because Canoeboot modifies coreboot to never download/handle microcode, even when microcode is enabled in a coreboot config. This patch does the same thing, but for disabling the download of 3rdparty blob repositories. Therefore, I can now keep canoeboot's coreboot configs more closely in sync with those of Libreboot, reducing the maintenance burden for each Canoeboot release. Signed-off-by: Leah Rowe --- Makefile.inc | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/Makefile.inc b/Makefile.inc index 96121d4019..6e8f7ec581 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -199,21 +199,6 @@ $(info Updating git submodules.) forgetthis:=$(shell git submodule update --init $(quiet_errors)) # Checkout Cmocka repository forgetthis:=$(shell git submodule update --init --checkout 3rdparty/cmocka $(quiet_errors)) -ifeq ($(CONFIG_USE_BLOBS),y) -# These items are necessary because each has update=none in .gitmodules. They are ignored -# until expressly requested and enabled with --checkout -forgetthis:=$(shell git submodule update --init --checkout 3rdparty/blobs $(quiet_errors)) -forgetthis:=$(shell git submodule update --init --checkout 3rdparty/intel-microcode $(quiet_errors)) -ifeq ($(CONFIG_FSP_USE_REPO),y) -forgetthis:=$(shell git submodule update --init --checkout 3rdparty/fsp $(quiet_errors)) -endif -ifeq ($(CONFIG_USE_AMD_BLOBS),y) -forgetthis:=$(shell git submodule update --init --checkout 3rdparty/amd_blobs $(quiet_errors)) -endif -ifeq ($(CONFIG_USE_QC_BLOBS),y) -forgetthis:=$(shell git submodule update --init --checkout 3rdparty/qc_blobs $(quiet_errors)) -endif -endif UPDATED_SUBMODULES:=1 COREBOOT_EXPORTS += UPDATED_SUBMODULES -- 2.39.2