From 444846dd2dfc9e3a5ea4904826c1c7a4b9b5589b Mon Sep 17 00:00:00 2001 From: Ariadne Conill Date: Mon, 7 Oct 2024 17:44:22 -0700 Subject: [PATCH] personality: drop want_default_pure on windows We still retain want_default_static to satisfy the requirements of the PE/COFF linking model. Fixes: 008d7069 ("libpkgconf: personality: default: set want_default_static and want_default_pure to true on windows") Signed-off-by: Ariadne Conill Closes: #364 --- libpkgconf/personality.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libpkgconf/personality.c b/libpkgconf/personality.c index 29447f2..29525fe 100644 --- a/libpkgconf/personality.c +++ b/libpkgconf/personality.c @@ -38,8 +38,13 @@ static unsigned default_personality_init = 0; static pkgconf_cross_personality_t default_personality = { .name = "default", #ifdef _WIN32 + /* PE/COFF uses a different linking model than ELF and Mach-O, where + * all transitive dependency references must be processed by the linker + * when linking the final executable image, even if those dependencies + * are pulled in as DLLs. + * This translates to always using --static on Windows targets. + */ .want_default_static = true, - .want_default_pure = true, #endif };