refactor: refactor things with Clippy's help

Merge branch 'refactor/clippy' of https://gitea.treehouse.systems/fortressia/echidna

See #23

clippy.toml

@@ -1 +0,0 @@
-"clippy::style" = "deny"

src/components/editor/mod.rs

@@ -21,8 +21,8 @@ impl EchidnaCoreEditor {
         // Without cloning it, for some reasons the Rust compiler complains about &this.to_imp().sourceview not being IsA<sourceview::View>
         this_imp.minimap.set_view(&this_imp.sourceview.clone());
 
-        if file.is_some() {
+        match file {
-            let file = file.unwrap();
+            Some(file) => {
                 let file_location = file
                     .location()
                     .expect("file is required to have a location");
@@ -73,6 +73,8 @@ impl EchidnaCoreEditor {
                 );
                 }
             }
+            None => {}
+        }
         this
     }
 

src/components/sidebar/mod.rs

@@ -15,3 +15,9 @@ impl EchidnaSidebar {
         glib::Object::new(&[]).expect("Failed to create 'EchidnaSidebar' component.")
     }
 }
+
+impl Default for EchidnaSidebar {
+    fn default() -> Self {
+        Self::new()
+    }
+}

src/components/tab_label/imp.rs

@@ -36,9 +36,9 @@ impl BuildableImpl for TabLabel {
     fn add_child(
         &self,
         buildable: &Self::Type,
-        builder: &gtk::Builder,
+        _builder: &gtk::Builder,
         child: &glib::Object,
-        type_: Option<&str>,
+        _type_: Option<&str>,
     ) {
         buildable.prepend(child.downcast_ref::<gtk::Widget>().unwrap());
     }

src/components/tab_label/mod.rs

@@ -17,8 +17,9 @@ impl TabLabel {
     pub fn new<U: IsA<gtk::Widget>>(tab_label: Option<&U>) -> Self {
         let this: Self = glib::Object::new(&[]).expect("Failed to create 'TabLabel' component.");
 
-        if tab_label.is_some() {
+        match tab_label {
-            this.prepend(tab_label.unwrap());
+            Some(tab_label) => this.prepend(tab_label),
+            None => {}
         }
         this
     }

src/components/window/file.rs

@@ -67,7 +67,7 @@ impl FileImplementedEditor for super::EchidnaWindow {
         notebook.prepend_closable_page(
             &editor_page,
             Some(&Label::new(Some(
-                &file_location
+                file_location
                     .path()
                     .expect("The file's path is missing")
                     .file_name()

src/lib/closeable_tab.rs

@@ -4,7 +4,7 @@
 
 use crate::components::tab_label::TabLabel;
 use glib::IsA;
-use gtk::{prelude::*, Box, Button, Widget};
+use gtk::{prelude::*, Widget};
 
 pub trait ClosableTabImplementedNotebook {
     fn prepend_closable_page<T: IsA<Widget>, U: IsA<Widget>>(