fortressia
/
echidna
1
1
Fork 0
Code Issues 15 Pull Requests 2 Projects Releases Wiki Activity

refactor: use gtk::show_uri() instead of webbrowser crate #17

Merged
fortressia merged 1 commits from refactor/gtk_show_uri_on_window into main 2021-12-17 02:32:52 +00:00
Conversation 2 Commits 1 Files Changed 3
fortressia commented 2021-12-13 05:45:54 +00:00 (Migrated from gitlab.com)

Description

Before this MR, we use a third-partycrate called webbrowser-rs, which is quite a bad idea, although I have no problem with the developer or the crate itself. First, GTK already got gtk::show_uri(), which makes using webbrowser-rs quite bloated. Second, relying on third party code, especially those that are not big, is prone to supply chain vulnerabilites and attacks, making it more important to use gtk::show_uri() rather than another third party code, as GTK is more professionally developed.
See https://twitter.com/FiloSottile/status/1469441487175880711 and the following XKCD:

image

Closes

N/A

Implementation Insight

N/A

TO-DOs

N/A

# Description Before this MR, we use a third-partycrate called [webbrowser-rs](https://github.com/amodm/webbrowser-rs), which is quite a bad idea, although I have no problem with the developer or the crate itself. First, GTK already got [`gtk::show_uri()`](https://gtk-rs.org/gtk4-rs/stable/latest/docs/gtk4/fn.show_uri.html), which makes using webbrowser-rs quite bloated. Second, relying on third party code, especially those that are not big, is prone to supply chain vulnerabilites and attacks, making it more important to use `gtk::show_uri()` rather than another third party code, as GTK is more professionally developed. See https://twitter.com/FiloSottile/status/1469441487175880711 and the following XKCD: [![image](/uploads/8fbd009ce012e4a273c7ae39e12daf31/image.png)]( https://www.explainxkcd.com/wiki/index.php/2347:_Dependency.) # Closes N/A # Implementation Insight N/A # TO-DOs N/A
fortressia commented 2021-12-13 05:45:55 +00:00 (Migrated from gitlab.com)

assigned to @fortressia

assigned to @fortressia
fortressia commented 2021-12-17 02:32:52 +00:00 (Migrated from gitlab.com)

mentioned in commit d98266255a

mentioned in commit d98266255ad9972491b19f4ea6a8fd88e098aa9d
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
   
documentation
   
duplicate
   
feat

Stands for 'feature', this label for new features.   
good first issue
   
help wanted
   
in-progress
   
invalid
   
question
   
refactor

This label for issues and MRs that rewrites code.   
wontfix
No Label
bug
documentation
duplicate
feat
good first issue
help wanted
in-progress
invalid
question
refactor
wontfix
Milestone
Clear milestone
No items
No Milestone
MVP
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fortressia/echidna#17
There is no content yet.
Delete Branch "refactor/gtk_show_uri_on_window"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?