feat: implement saving file normally #21

fortressia · 2021-12-16T07:15:39Z

fortressia commented

2021-12-16 07:15:39 +00:00

(Migrated from gitlab.com)

Description

This MR implements saving file as in "Save File" and not "Save File As" and the "Save" menu, with several refactors needed for the main commit of this PR to be implemented.

Closes

#23

Implementation Insight

Quite some code that can be reused in another parts of Echidna isn't independent, so I refactor them into separate functions.

TO-DOs

N/A. Everything is completed.

# Description This MR implements saving file as in "Save File" and not "Save File As" and the "Save" menu, with several refactors needed for the main commit of this PR to be implemented. # Closes #23 # Implementation Insight Quite some code that can be reused in another parts of Echidna isn't independent, so I refactor them into separate functions. # TO-DOs N/A. Everything is completed.

fortressia commented

2021-12-16 07:15:40 +00:00

(Migrated from gitlab.com)

assigned to @fortressia

fortressia commented

2021-12-16 07:16:29 +00:00

(Migrated from gitlab.com)

changed title from feat: implement {-"Save" menu-} to feat: implement {+saving file normally+}

changed title from **feat: implement {-"Save" menu-}** to **feat: implement {+saving file normally+}**

fortressia commented

2021-12-16 07:16:29 +00:00

(Migrated from gitlab.com)

changed the description

fortressia commented

2021-12-18 04:53:27 +00:00

(Migrated from gitlab.com)

added 20 commits

d8c7f104...e3b330a5 - 19 commits from branch main
5e574299 - Merge branch 'main' into 'feat/save'

Compare with previous version

added 20 commits <ul><li>d8c7f104...e3b330a5 - 19 commits from branch <code>main</code></li><li>5e574299 - Merge branch 'main' into 'feat/save'</li></ul> [Compare with previous version](/EchidnaHQ/Echidna/-/merge_requests/21/diffs?diff_id=298655885&start_sha=d8c7f104abb93fba53f1966cf123b47f5f96335a)

fortressia commented

2021-12-18 04:53:48 +00:00

(Migrated from gitlab.com)

requested review from @VoltrexMaster

fortressia commented

2021-12-18 07:28:16 +00:00

(Migrated from gitlab.com)

marked this merge request as draft

marked this merge request as **draft**

fortressia commented

2021-12-18 07:28:18 +00:00

(Migrated from gitlab.com)