From 017fc81caf8f265e5c5543186877437485625795 Mon Sep 17 00:00:00 2001 From: David Yip Date: Wed, 6 Dec 2017 16:19:43 -0600 Subject: [PATCH] Prepend check_enabled_deletion to Settings::DeletesController (#229) The specs for Settings::DeletesController include an example that sets Settings.open_deletion to false and expects the "if deletion is not available, redirect to root" logic to run. However, this spec does not set up a user, which means that the spec (intentionally or otherwise) expects this redirection to work with unauthenticated access. We should preserve that behavior. To do so, we prepend the deletion check to the action chain set up by Settings::BaseController, so that said check occurs before the authenticate_user! check. --- app/controllers/settings/deletes_controller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/settings/deletes_controller.rb b/app/controllers/settings/deletes_controller.rb index e4cb35a8e9d..4c112147114 100644 --- a/app/controllers/settings/deletes_controller.rb +++ b/app/controllers/settings/deletes_controller.rb @@ -2,7 +2,7 @@ class Settings::DeletesController < Settings::BaseController - before_action :check_enabled_deletion + prepend_before_action :check_enabled_deletion def show @confirmation = Form::DeleteConfirmation.new