From b6f6152e263cdf12f61f9ae3d65c351a4dec7c61 Mon Sep 17 00:00:00 2001
From: Matt Jankowski <mjankowski@thoughtbot.com>
Date: Fri, 19 May 2017 17:32:37 -0400
Subject: [PATCH] Add coverage for api/v1 controllers (#3155)

---
 .../api/v1/accounts_controller_spec.rb        |  8 +++++
 .../api/v1/instances_controller_spec.rb       | 22 +++++++++++++
 .../api/v1/notifications_controller_spec.rb   | 29 +++++++++++++++++
 .../api/v1/reports_controller_spec.rb         | 32 +++++++++++++++++++
 .../api/v1/search_controller_spec.rb          | 22 +++++++++++++
 5 files changed, 113 insertions(+)
 create mode 100644 spec/controllers/api/v1/instances_controller_spec.rb
 create mode 100644 spec/controllers/api/v1/reports_controller_spec.rb
 create mode 100644 spec/controllers/api/v1/search_controller_spec.rb

diff --git a/spec/controllers/api/v1/accounts_controller_spec.rb b/spec/controllers/api/v1/accounts_controller_spec.rb
index d69d9c4c2be..041b279f70b 100644
--- a/spec/controllers/api/v1/accounts_controller_spec.rb
+++ b/spec/controllers/api/v1/accounts_controller_spec.rb
@@ -17,6 +17,14 @@ RSpec.describe Api::V1::AccountsController, type: :controller do
     end
   end
 
+  describe 'GET #search' do
+    it 'returns http success' do
+      get :search, params: { q: 'query' }
+
+      expect(response).to have_http_status(:success)
+    end
+  end
+
   describe 'GET #verify_credentials' do
     it 'returns http success' do
       get :verify_credentials
diff --git a/spec/controllers/api/v1/instances_controller_spec.rb b/spec/controllers/api/v1/instances_controller_spec.rb
new file mode 100644
index 00000000000..544f3d28f81
--- /dev/null
+++ b/spec/controllers/api/v1/instances_controller_spec.rb
@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe Api::V1::InstancesController, type: :controller do
+  render_views
+
+  let(:user)  { Fabricate(:user, account: Fabricate(:account, username: 'alice')) }
+  let(:token) { double acceptable?: true, resource_owner_id: user.id }
+
+  before do
+    allow(controller).to receive(:doorkeeper_token) { token }
+  end
+
+  describe 'GET #show' do
+    it 'returns http success' do
+      get :show
+
+      expect(response).to have_http_status(:success)
+    end
+  end
+end
diff --git a/spec/controllers/api/v1/notifications_controller_spec.rb b/spec/controllers/api/v1/notifications_controller_spec.rb
index e3c95309417..e06230913a9 100644
--- a/spec/controllers/api/v1/notifications_controller_spec.rb
+++ b/spec/controllers/api/v1/notifications_controller_spec.rb
@@ -11,6 +11,35 @@ RSpec.describe Api::V1::NotificationsController, type: :controller do
     allow(controller).to receive(:doorkeeper_token) { token }
   end
 
+  describe 'GET #show' do
+    it 'returns http success' do
+      notification = Fabricate(:notification, account: user.account)
+      get :show, params: { id: notification.id }
+
+      expect(response).to have_http_status(:success)
+    end
+  end
+
+  describe 'POST #dismiss' do
+    it 'destroys the notification' do
+      notification = Fabricate(:notification, account: user.account)
+      post :dismiss, params: { id: notification.id }
+
+      expect(response).to have_http_status(:success)
+      expect { notification.reload }.to raise_error(ActiveRecord::RecordNotFound)
+    end
+  end
+
+  describe 'POST #clear' do
+    it 'clears notifications for the account' do
+      notification = Fabricate(:notification, account: user.account)
+      post :clear
+
+      expect(notification.account.reload.notifications).to be_empty
+      expect(response).to have_http_status(:success)
+    end
+  end
+
   describe 'GET #index' do
     before do
       first_status = PostStatusService.new.call(user.account, 'Test')
diff --git a/spec/controllers/api/v1/reports_controller_spec.rb b/spec/controllers/api/v1/reports_controller_spec.rb
new file mode 100644
index 00000000000..3df6cdfe746
--- /dev/null
+++ b/spec/controllers/api/v1/reports_controller_spec.rb
@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe Api::V1::ReportsController, type: :controller do
+  render_views
+
+  let(:user)  { Fabricate(:user, account: Fabricate(:account, username: 'alice')) }
+  let(:token) { double acceptable?: true, resource_owner_id: user.id }
+
+  before do
+    allow(controller).to receive(:doorkeeper_token) { token }
+  end
+
+  describe 'GET #index' do
+    it 'returns http success' do
+      get :index
+
+      expect(response).to have_http_status(:success)
+    end
+  end
+
+  describe 'POST #create' do
+    it 'creates a report' do
+      status = Fabricate(:status)
+      post :create, params: { status_ids: [status.id], account_id: status.account.id, comment: 'reasons' }
+
+      expect(status.reload.account.targeted_reports).not_to be_empty
+      expect(response).to have_http_status(:success)
+    end
+  end
+end
diff --git a/spec/controllers/api/v1/search_controller_spec.rb b/spec/controllers/api/v1/search_controller_spec.rb
new file mode 100644
index 00000000000..4d22ddc98fc
--- /dev/null
+++ b/spec/controllers/api/v1/search_controller_spec.rb
@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe Api::V1::SearchController, type: :controller do
+  render_views
+
+  let(:user)  { Fabricate(:user, account: Fabricate(:account, username: 'alice')) }
+  let(:token) { double acceptable?: true, resource_owner_id: user.id }
+
+  before do
+    allow(controller).to receive(:doorkeeper_token) { token }
+  end
+
+  describe 'GET #index' do
+    it 'returns http success' do
+      get :index, params: { q: 'test' }
+
+      expect(response).to have_http_status(:success)
+    end
+  end
+end