Helper cleanup (#1348)

* Remove unused helper files

* Add coverage for application helper

* Add coverage for StreamEntriesHelper #display_name
signup-info-prompt
Matt Jankowski 2017-04-09 11:11:37 -04:00 committed by Eugen
parent 12e29c9660
commit ea6c930c04
14 changed files with 26 additions and 56 deletions

View File

@ -1,4 +0,0 @@
# frozen_string_literal: true
module AboutHelper
end

View File

@ -1,4 +0,0 @@
# frozen_string_literal: true
module Admin::DomainBlocksHelper
end

View File

@ -1,4 +0,0 @@
# frozen_string_literal: true
module Admin::PubsubhubbubHelper
end

View File

@ -1,4 +0,0 @@
# frozen_string_literal: true
module AuthorizeFollowHelper
end

View File

@ -1,4 +0,0 @@
# frozen_string_literal: true
module TagsHelper
end

View File

@ -1,4 +0,0 @@
# frozen_string_literal: true
module XrdHelper
end

View File

@ -1,5 +0,0 @@
require 'rails_helper'
RSpec.describe AboutHelper, type: :helper do
end

View File

@ -1,5 +0,0 @@
require 'rails_helper'
RSpec.describe Admin::DomainBlocksHelper, type: :helper do
end

View File

@ -1,5 +0,0 @@
require 'rails_helper'
RSpec.describe Admin::PubsubhubbubHelper, type: :helper do
end

View File

@ -1,5 +1,19 @@
require 'rails_helper' require 'rails_helper'
RSpec.describe ApplicationHelper, type: :helper do describe ApplicationHelper do
describe 'active_nav_class' do
it 'returns active when on the current page' do
allow(helper).to receive(:current_page?).and_return(true)
result = helper.active_nav_class("/test")
expect(result).to eq "active"
end
it 'returns empty string when not on current page' do
allow(helper).to receive(:current_page?).and_return(false)
result = helper.active_nav_class("/test")
expect(result).to eq ""
end
end
end end

View File

@ -1,5 +0,0 @@
require 'rails_helper'
RSpec.describe AuthorizeFollowHelper, type: :helper do
end

View File

@ -2,7 +2,17 @@ require 'rails_helper'
RSpec.describe StreamEntriesHelper, type: :helper do RSpec.describe StreamEntriesHelper, type: :helper do
describe '#display_name' do describe '#display_name' do
pending it 'uses the display name when it exists' do
account = Account.new(display_name: "Display", username: "Username")
expect(helper.display_name(account)).to eq "Display"
end
it 'uses the username when display name is nil' do
account = Account.new(display_name: nil, username: "Username")
expect(helper.display_name(account)).to eq "Username"
end
end end
describe '#avatar_for_status_url' do describe '#avatar_for_status_url' do

View File

@ -1,5 +0,0 @@
require 'rails_helper'
RSpec.describe TagsHelper, type: :helper do
end

View File

@ -1,5 +0,0 @@
require 'rails_helper'
RSpec.describe XrdHelper, type: :helper do
end