From f729cfc881a7e944c706e0dfc0f689b82613b680 Mon Sep 17 00:00:00 2001 From: Eugen Rochko Date: Thu, 22 Dec 2016 23:14:24 +0100 Subject: [PATCH] Private posts mentioning non-followers should not notify them, neither locally nor via Salmon --- app/lib/feed_manager.rb | 1 + app/services/process_mentions_service.rb | 2 ++ 2 files changed, 3 insertions(+) diff --git a/app/lib/feed_manager.rb b/app/lib/feed_manager.rb index c07e4b05f96..c6262f21136 100644 --- a/app/lib/feed_manager.rb +++ b/app/lib/feed_manager.rb @@ -96,6 +96,7 @@ class FeedManager should_filter ||= receiver.blocking?(status.account) # or it's from someone I blocked should_filter ||= receiver.blocking?(status.mentions.includes(:account).map(&:account)) # or if it mentions someone I blocked should_filter ||= (status.account.silenced? && !receiver.following?(status.account)) # of if the account is silenced and I'm not following them + should_filter ||= (status.private_visibility? && !receiver.following?(status.account)) # or if the mentioned account is not permitted to see the private status if status.reply? && !status.thread.account.nil? # or it's a reply should_filter ||= receiver.blocking?(status.thread.account) # to a user I blocked diff --git a/app/services/process_mentions_service.rb b/app/services/process_mentions_service.rb index 98e48299e62..ee42a5df24e 100644 --- a/app/services/process_mentions_service.rb +++ b/app/services/process_mentions_service.rb @@ -28,6 +28,8 @@ class ProcessMentionsService < BaseService status.mentions.each do |mention| mentioned_account = mention.account + next if status.private_visibility? && !mentioned_account.following?(status.account) + if mentioned_account.local? NotifyService.new.call(mentioned_account, mention) else