From 9f3fbedcc9b45c0d48e222dd52568ced8ca22954 Mon Sep 17 00:00:00 2001 From: Natanael Copa Date: Fri, 26 Feb 2010 12:52:35 +0000 Subject: [PATCH] add: print all failing packages instead of only first We want see all packages that fails to install and not only the first --- src/add.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/add.c b/src/add.c index 4d31b87..17935c8 100644 --- a/src/add.c +++ b/src/add.c @@ -63,7 +63,7 @@ static int add_main(void *ctx, struct apk_database *db, int argc, char **argv) struct apk_package *virtpkg = NULL; struct apk_dependency virtdep; struct apk_dependency *deps; - int i, r = 0, num_deps = 0; + int i, r = 0, num_deps = 0, errors = 0; if (actx->virtpkg) { if (non_repository_check(db)) @@ -136,10 +136,12 @@ static int add_main(void *ctx, struct apk_database *db, int argc, char **argv) } else { apk_error("Unable to install '%s': %d", deps[i].name->name, r); - if (!(apk_flags & APK_FORCE)) - goto err; + errors++; } } + if (errors && !(apk_flags & APK_FORCE)) + goto err; + r = apk_state_commit(state, db); err: if (state != NULL)