From a278d112877a0c347e42694d399d62ebbafc1dee Mon Sep 17 00:00:00 2001 From: "Alex Xu (Hello71)" Date: Sat, 7 Aug 2021 08:33:23 -0400 Subject: [PATCH] test: improve posix sh compatibility --- test/Makefile | 4 ++-- test/solver.sh | 4 ++-- test/version.sh | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/test/Makefile b/test/Makefile index 9834668..a48387d 100644 --- a/test/Makefile +++ b/test/Makefile @@ -50,9 +50,9 @@ repos.stamp: $(repos) fi; \ if ! APK="$(APK)" ROOT="$(testroot)" SYSREPO="$(SYSREPO)" sh -ex ./$< > $(basename $@).out 2>&1; then\ echo " FAIL";\ - printf "------------- output -------------\n" >&2;\ + printf '%s\n' "------------- output -------------" >&2;\ cat $(basename $@).out >&2;\ - printf "----------------------------------\n" >&2;\ + printf '%s\n' "----------------------------------" >&2;\ exit 1;\ fi ;\ echo " OK" ;\ diff --git a/test/solver.sh b/test/solver.sh index d14d89d..4c9f50d 100755 --- a/test/solver.sh +++ b/test/solver.sh @@ -10,9 +10,9 @@ TEST_TO_RUN="$@" fail=0 pass=0 for test in ${TEST_TO_RUN:-*.test}; do - get_block ARGS < $test | xargs $APK_TEST &> .$test.got + get_block ARGS < $test | xargs $APK_TEST > .$test.got 2>&1 - if ! get_block EXPECT < $test | cmp .$test.got &> /dev/null; then + if ! get_block EXPECT < $test | cmp .$test.got > /dev/null 2>&1; then fail=$((fail+1)) echo "FAIL: $test" get_block EXPECT < $test | diff -ru - .$test.got diff --git a/test/version.sh b/test/version.sh index 18199a6..628a6eb 100755 --- a/test/version.sh +++ b/test/version.sh @@ -9,7 +9,7 @@ cat version.data | while read a result b rest ; do fi done -if [ "$fail" == "0" ]; then +if [ "$fail" = "0" ]; then echo "OK: version checking works" fi