From c3a93a4aa588f237690953fc74011c3bd00ed2ae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timo=20Ter=C3=A4s?= Date: Wed, 5 Jun 2019 09:32:29 +0300 Subject: [PATCH] fix all applets to return -ENOTSUP if it's unrecognized The return -1 seems to have been left over from earlier code, and could have been treated as -EPERM. This helps to fix the other command line handling that potentially require changing. --- src/info.c | 2 +- src/list.c | 2 +- src/search.c | 2 +- src/upgrade.c | 2 +- src/ver.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/info.c b/src/info.c index ff79eaa..9a37e1e 100644 --- a/src/info.c +++ b/src/info.c @@ -416,7 +416,7 @@ static int option_parse_applet(void *pctx, struct apk_db_options *dbopts, int op ctx->subaction_mask = 0xffffffff; break; default: - return -1; + return -ENOTSUP; } return 0; } diff --git a/src/list.c b/src/list.c index 202dab2..593e7d2 100644 --- a/src/list.c +++ b/src/list.c @@ -220,7 +220,7 @@ static int option_parse_applet(void *pctx, struct apk_db_options *dbopts, int op ctx->match_providers = 1; break; default: - return -1; + return -ENOTSUP; } return 0; diff --git a/src/search.c b/src/search.c index 62ca816..9a71747 100644 --- a/src/search.c +++ b/src/search.c @@ -103,7 +103,7 @@ static int option_parse_applet(void *ctx, struct apk_db_options *dbopts, int opt ictx->show_all = 1; break; default: - return -1; + return -ENOTSUP; } return 0; } diff --git a/src/upgrade.c b/src/upgrade.c index 14457b5..6c3eafa 100644 --- a/src/upgrade.c +++ b/src/upgrade.c @@ -42,7 +42,7 @@ static int option_parse_applet(void *ctx, struct apk_db_options *dbopts, int opt uctx->solver_flags |= APK_SOLVERF_LATEST; break; default: - return -1; + return -ENOTSUP; } return 0; } diff --git a/src/ver.c b/src/ver.c index 0792937..3a08359 100644 --- a/src/ver.c +++ b/src/ver.c @@ -90,7 +90,7 @@ static int option_parse_applet(void *ctx, struct apk_db_options *dbopts, int opt ictx->all_tags = 1; break; default: - return -1; + return -ENOTSUP; } return 0; }