jaiden
/
apk-tools
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fetch: fix fd leak 

we should always close the in-stream, not only on failure.
cute-signatures
Natanael Copa 2009-05-26 14:12:02 +00:00
parent fed1474d5a
commit c8c9851369
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/fetch.c
View File

@ -95,10 +95,10 @@ static int fetch_package(struct fetch_ctx *fctx,
} }
r = apk_istream_splice(is, fd, pkg->size, NULL, NULL); r = apk_istream_splice(is, fd, pkg->size, NULL, NULL);
is->close(is);
if (fd != STDOUT_FILENO) if (fd != STDOUT_FILENO)
close(fd); close(fd);
if (r != pkg->size) { if (r != pkg->size) {
is->close(is);
apk_error("Unable to download '%s'", file); apk_error("Unable to download '%s'", file);
unlink(file); unlink(file);
return -1; return -1;