jaiden
/
apk-tools
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

libfetch: fix use-after-free in connection cache management 

fixes #10734
cute-signatures
Timo Teräs 2021-01-19 16:10:08 +02:00
parent 4087ab92c4
commit d430a98976
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libfetch/common.c
View File

@ -381,7 +381,7 @@ fetch_cache_get(const struct url *url, int af)
void void
fetch_cache_put(conn_t *conn, int (*closecb)(conn_t *)) fetch_cache_put(conn_t *conn, int (*closecb)(conn_t *))
{ {
conn_t *iter, *last; conn_t *iter, *last, *next_cached;
int global_count, host_count; int global_count, host_count;
if (conn->cache_url == NULL || cache_global_limit == 0) { if (conn->cache_url == NULL || cache_global_limit == 0) {
@ -391,8 +391,8 @@ fetch_cache_put(conn_t *conn, int (*closecb)(conn_t *))
global_count = host_count = 0; global_count = host_count = 0;
last = NULL; last = NULL;
for (iter = connection_cache; iter; for (iter = connection_cache; iter; last = iter, iter = next_cached) {
last = iter, iter = iter->next_cached) { next_cached = iter->next_cached;
++global_count; ++global_count;
if (strcmp(conn->cache_url->host, iter->cache_url->host) == 0) if (strcmp(conn->cache_url->host, iter->cache_url->host) == 0)
++host_count; ++host_count;