database: clarify the deprecation notice for checksum-less packages

Closes #10708.
cute-signatures
Ariadne Conill 2020-08-29 08:34:00 -06:00 committed by Timo Teräs
parent d5dcaeb1cd
commit fa63e46a75
1 changed files with 7 additions and 3 deletions

View File

@ -81,6 +81,7 @@ struct install_ctx {
int script; int script;
char **script_args; char **script_args;
int script_pending : 1; int script_pending : 1;
int missing_checksum : 1;
struct apk_db_dir_instance *diri; struct apk_db_dir_instance *diri;
struct apk_checksum data_csum; struct apk_checksum data_csum;
@ -2570,10 +2571,13 @@ static int apk_db_install_archive_entry(void *_ctx,
memcpy(&file->csum, &link_target_file->csum, sizeof file->csum); memcpy(&file->csum, &link_target_file->csum, sizeof file->csum);
else else
memcpy(&file->csum, &ae->csum, sizeof file->csum); memcpy(&file->csum, &ae->csum, sizeof file->csum);
if (file->csum.type == APK_CHECKSUM_NONE) { /* only warn once per package */
apk_warning(PKG_VER_FMT": no checksum for file %s", if (file->csum.type == APK_CHECKSUM_NONE && !ctx->missing_checksum) {
PKG_VER_PRINTF(pkg), ae->name); apk_warning(PKG_VER_FMT": support for packages without embedded "
"checksums will be dropped in apk-tools 3.",
PKG_VER_PRINTF(pkg));
ipkg->broken_files = 1; ipkg->broken_files = 1;
ctx->missing_checksum = 1;
} }
break; break;
case -ENOTSUP: case -ENOTSUP: