kode54
/
cog
2
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix some more warnings.

CQTexperiment
Dzmitry Neviadomski 2021-01-27 05:12:07 +03:00
parent 64b9764b2e
commit 70a22e9611
21 changed files with 29 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Audio/Chain/Node.m
View File

@ -9,6 +9,7 @@
#import "Node.h"
#import "Logging.h"
#import "BufferChain.h"
@implementation Node

1
Audio/CogAudio_Prefix.pch
View File

@ -3,5 +3,6 @@
//
#ifdef __OBJC__
#import <AssertMacros.h>
#import <Cocoa/Cocoa.h>
#endif

2
Plugins/AdPlug/AdPlug/AdPlugContainer.mm
View File

@ -51,7 +51,7 @@
Copl * p_emu = new CSilentopl;
std::string path = [[[url absoluteString] stringByReplacingPercentEscapesUsingEncoding:NSUTF8StringEncoding] UTF8String];
std::string path = [[[url absoluteString] stringByRemovingPercentEncoding] UTF8String];
CPlayer * p_player = CAdPlug::factory(path, p_emu, CAdPlug::players, CProvider_cog( path, source ));
if ( !p_player )

2
Plugins/AdPlug/AdPlug/AdPlugDecoder.mm
View File

@ -40,7 +40,7 @@
path = [path substringToIndex:fragmentRange.location];
}
std::string _path = [[path stringByReplacingPercentEscapesUsingEncoding:NSUTF8StringEncoding] UTF8String];
std::string _path = [[path stringByRemovingPercentEncoding] UTF8String];
m_player = CAdPlug::factory(_path, m_emu, CAdPlug::players, CProvider_cog( _path, source ));
if ( !m_player )

2
Plugins/AdPlug/AdPlug/AdPlugMetadataReader.mm
View File

@ -52,7 +52,7 @@
path = [path substringToIndex:fragmentRange.location];
}
std::string _path = [[path stringByReplacingPercentEscapesUsingEncoding:NSUTF8StringEncoding] UTF8String];
std::string _path = [[path stringByRemovingPercentEncoding] UTF8String];
CPlayer * p_player = CAdPlug::factory(_path, p_emu, CAdPlug::players, CProvider_cog( _path, source ));
if ( !p_player )

2
Plugins/AdPlug/AdPlug/fileprovider.mm
View File

@ -100,7 +100,7 @@ binistream * CProvider_cog::open(std::string filename) const
fragmentString = [urlString substringFromIndex:fragmentRange.location];
urlString = [urlString substringToIndex:fragmentRange.location];
}
NSURL * url = [NSURL URLWithString:[[urlString stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding] stringByAppendingString:fragmentString]];
NSURL * url = [NSURL URLWithString:[[urlString stringByAddingPercentEncodingWithAllowedCharacters:NSCharacterSet.URLFragmentAllowedCharacterSet] stringByAppendingString:fragmentString]];
id audioSourceClass = NSClassFromString(@"AudioSource");
p_file = [audioSourceClass audioSourceForURL:url];

2
Plugins/ArchiveSource/ArchiveSource/ArchiveContainer.m
View File

@ -62,7 +62,7 @@ static NSString * g_make_unpack_path(NSString * archive, NSString * file, NSStri
while ( !fex_done(fex) ) {
NSString *name = [NSString stringWithUTF8String:fex_name(fex)];
if ([[NSClassFromString(@"AudioPlayer") fileTypes] containsObject:[[name pathExtension] lowercaseString]])
[files addObject:[NSURL URLWithString:[g_make_unpack_path([url path], name, @"fex") stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]]];
[files addObject:[NSURL URLWithString:[g_make_unpack_path([url path], name, @"fex") stringByAddingPercentEncodingWithAllowedCharacters:NSCharacterSet.URLPathAllowedCharacterSet]]];
fex_next(fex);
}

2
Plugins/ArchiveSource/ArchiveSource/ArchiveSource.m
View File

@ -75,7 +75,7 @@ static BOOL g_parse_unpack_path(NSString * src, NSString ** archive, NSString **
{
[self setURL:url];
NSString * urlDecoded = [[url absoluteString] stringByReplacingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
NSString * urlDecoded = [[url absoluteString] stringByRemovingPercentEncoding];
NSString * type;
NSString * archive;

4
Plugins/FFMPEG/FFMPEGDecoder.m
View File

@ -80,8 +80,6 @@ int lockmgr_callback(void ** mutex, enum AVLockOp op)
{
av_log_set_flags(AV_LOG_SKIP_REPEATED);
av_log_set_level(AV_LOG_ERROR);
av_register_all();
av_lockmgr_register(lockmgr_callback);
}
}
@ -190,8 +188,6 @@ int lockmgr_callback(void ** mutex, enum AVLockOp op)
ALog(@"Can't copy codec parameters to context, errcode = %d, error = %s", errcode, errDescr);
return NO;
}
av_codec_set_pkt_timebase(codecCtx, stream->time_base);
AVCodec * codec = avcodec_find_decoder(codecCtx->codec_id);
if (!codec) {

2
Plugins/MIDI/MIDI.xcodeproj/project.pbxproj
View File

@ -508,6 +508,7 @@
GCC_SYMBOLS_PRIVATE_EXTERN = NO;
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
GCC_WARN_INHIBIT_ALL_WARNINGS = YES;
GCC_WARN_UNDECLARED_SELECTOR = YES;
GCC_WARN_UNINITIALIZED_AUTOS = YES;
GCC_WARN_UNUSED_FUNCTION = YES;
@ -554,6 +555,7 @@
GCC_NO_COMMON_BLOCKS = YES;
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
GCC_WARN_INHIBIT_ALL_WARNINGS = YES;
GCC_WARN_UNDECLARED_SELECTOR = YES;
GCC_WARN_UNINITIALIZED_AUTOS = YES;
GCC_WARN_UNUSED_FUNCTION = YES;

6
Plugins/MIDI/MIDI/AUPlayerView.mm
View File

@ -30,7 +30,11 @@ AUPluginUI::AUPluginUI (AudioUnit & _au)
}
if (au_view) {
cocoa_window = [[NSWindow alloc] initWithContentRect:NSMakeRect(0, 0, req_width, req_height) styleMask:(NSTitledWindowMask | NSClosableWindowMask) backing:NSBackingStoreBuffered defer:NO];
cocoa_window = [[NSWindow alloc] initWithContentRect:NSMakeRect(0, 0, req_width, req_height)
styleMask:(NSWindowStyleMaskTitled |
NSWindowStyleMaskClosable)
backing:NSBackingStoreBuffered
defer:NO];
[cocoa_window setAutodisplay:YES];
[cocoa_window setTitle:@"AU Plug-in"];

4
Plugins/OpenMPT/OpenMPT.xcodeproj/project.pbxproj
View File

@ -248,7 +248,7 @@
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
CLANG_WARN_DOCUMENTATION_COMMENTS = NO;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_INFINITE_RECURSION = YES;
@ -305,7 +305,7 @@
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
CLANG_WARN_DOCUMENTATION_COMMENTS = NO;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_INFINITE_RECURSION = YES;

2
Plugins/OpenMPT/OpenMPT/OMPTDecoder.mm
View File

@ -81,7 +81,7 @@ static void g_push_archive_extensions(std::vector<std::string> & list)
mod->set_render_param( openmpt::module::RENDER_STEREOSEPARATION_PERCENT, 100 );
mod->set_render_param( openmpt::module::RENDER_INTERPOLATIONFILTER_LENGTH, interp );
mod->set_render_param( openmpt::module::RENDER_VOLUMERAMPING_STRENGTH, -1 );
mod->ctl_set( "render.resampler.emulate_amiga", "1" );
mod->ctl_set_boolean("render.resampler.emulate_amiga", true);
left.resize( 1024 );
right.resize( 1024 );

2
Plugins/TagLib/TagLibMetadataReader.m
View File

@ -148,7 +148,7 @@
// Gather list of candidate image files
NSArray *fileNames = [[NSFileManager defaultManager] contentsOfDirectoryAtPath:path error:nil];
NSArray *imageFileNames = [fileNames pathsMatchingExtensions:[NSImage imageFileTypes]];
NSArray *imageFileNames = [fileNames pathsMatchingExtensions:[NSImage imageTypes]];
for (NSString *fileName in imageFileNames) {
if ([TagLibMetadataReader isCoverFile:fileName]) {

4
Plugins/TagLib/TagLibMetadataWriter.m
View File

@ -8,8 +8,8 @@
#import "TagLibMetadataWriter.h"
#import <TagLib/fileref.h>
#import <TagLib/tag.h>
#import <taglib/fileref.h>
#import <taglib/tag.h>
#import "Logging.h"

2
Plugins/vgmstream/vgmstream.xcodeproj/project.pbxproj
View File

@ -332,6 +332,7 @@
GCC_SYMBOLS_PRIVATE_EXTERN = NO;
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
GCC_WARN_INHIBIT_ALL_WARNINGS = YES;
GCC_WARN_UNDECLARED_SELECTOR = YES;
GCC_WARN_UNINITIALIZED_AUTOS = YES;
GCC_WARN_UNUSED_FUNCTION = YES;
@ -393,6 +394,7 @@
);
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
GCC_WARN_INHIBIT_ALL_WARNINGS = YES;
GCC_WARN_UNDECLARED_SELECTOR = YES;
GCC_WARN_UNINITIALIZED_AUTOS = YES;
GCC_WARN_UNUSED_FUNCTION = YES;

2
Plugins/vgmstream/vgmstream/VGMContainer.m
View File

@ -36,7 +36,7 @@
return [NSMutableArray arrayWithObject:url];
}
NSString * path = [[url absoluteString] stringByReplacingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
NSString * path = [[url absoluteString] stringByRemovingPercentEncoding];
VGMSTREAM * stream = init_vgmstream_from_cogfile([path UTF8String], 0);
if (!stream)

2
Plugins/vgmstream/vgmstream/VGMDecoder.m
View File

@ -194,7 +194,7 @@
NSLog(@"Opening %@ subsong %d", path, track_num);
stream = init_vgmstream_from_cogfile([[path stringByReplacingPercentEscapesUsingEncoding:NSUTF8StringEncoding] UTF8String], track_num);
stream = init_vgmstream_from_cogfile([[path stringByRemovingPercentEncoding] UTF8String], track_num);
if ( !stream )
return NO;

4
Plugins/vgmstream/vgmstream/VGMInterface.m
View File

@ -82,7 +82,7 @@ static STREAMFILE *cogsf_create(id file, const char *path) {
STREAMFILE *cogsf_create_from_path(const char *path) {
NSString * urlString = [NSString stringWithUTF8String:path];
NSURL * url = [NSURL URLWithString:[urlString stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]];
NSURL * url = [NSURL URLWithString:[urlString stringByAddingPercentEncodingWithAllowedCharacters:NSCharacterSet.URLPathAllowedCharacterSet]];
return cogsf_create_from_url(url);
}
@ -98,7 +98,7 @@ STREAMFILE *cogsf_create_from_url(NSURL * url) {
if (![source seekable])
return 0;
return cogsf_create(source, [[[url absoluteString] stringByReplacingPercentEscapesUsingEncoding:NSUTF8StringEncoding] UTF8String]);
return cogsf_create(source, [[[url absoluteString] stringByRemovingPercentEncoding] UTF8String]);
}
VGMSTREAM *init_vgmstream_from_cogfile(const char *path, int subsong) {

2
Plugins/vgmstream/vgmstream/VGMMetadataReader.m
View File

@ -42,7 +42,7 @@
path = [path substringToIndex:fragmentRange.location];
}
VGMSTREAM * stream = init_vgmstream_from_cogfile([[path stringByReplacingPercentEscapesUsingEncoding:NSUTF8StringEncoding] UTF8String], track_num);
VGMSTREAM * stream = init_vgmstream_from_cogfile([[path stringByRemovingPercentEncoding] UTF8String], track_num);
if ( !stream )
return nil;

2
Plugins/vgmstream/vgmstream/VGMPropertiesReader.m
View File

@ -44,7 +44,7 @@
path = [path substringToIndex:fragmentRange.location];
}
VGMSTREAM * stream = init_vgmstream_from_cogfile([[path stringByReplacingPercentEscapesUsingEncoding:NSUTF8StringEncoding] UTF8String], track_num);
VGMSTREAM * stream = init_vgmstream_from_cogfile([[path stringByRemovingPercentEncoding] UTF8String], track_num);
if ( !stream )
return nil;