kode54
/
cog
2
1
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[MAD Decoder] Don't crash on bad files 

The local and seekable file scanner could crash on bad MPEG files if
they failed to decode any frames and broke due to either end of file or
other unrecoverable errors, due to a division by zero error attempting
to calculate the file bitrate. Now correctly return error state if this
occurs, bailing early.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
main
Christopher Snowhill 2022-07-15 22:51:04 -07:00
parent 47258b02b1
commit dc536eef3d
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Plugins/MAD/MADDecoder.m
View File

@ -406,6 +406,11 @@
} }
} }
// Don't commit division by zero on bad files
if(stream.next_frame == stream.this_frame) {
return NO;
}
if(!_foundiTunSMPB && !_foundXingHeader && !_foundVBRIHeader) { if(!_foundiTunSMPB && !_foundXingHeader && !_foundVBRIHeader) {
// Now do CBR estimation instead of full file scanning // Now do CBR estimation instead of full file scanning
size_t frameCount = (_fileSize - id3_length) / (stream.next_frame - stream.this_frame); size_t frameCount = (_fileSize - id3_length) / (stream.next_frame - stream.this_frame);