Commit Graph

47 Commits (main)

Author SHA1 Message Date
Christopher Snowhill dd630ba394
File Tree: Reduce monitoring to limited changes
Only track new, removed, or renamed files. Tracking Xattr changes was
apparently causing the tracker dialog to crash on things like the user
changing file type associations, which either added or removed a per-
file association xattr, or when clicking Change All, removed this xattr
from all associated files tracked by Spotlight.

Fixes #361

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2023-06-04 01:37:46 -07:00
Christopher Snowhill 3ff9d079d7 [File Tree] Only free Smart Folder query if used
Only free the query if it was successfully allocated.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2022-07-27 06:35:45 -07:00
Christopher Snowhill 9113051840 [File Tree] Ask Sandbox for access to Smart Folder
Ask for access to Smart Folder dictionary file, to read its query.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2022-07-27 06:35:04 -07:00
Christopher Snowhill da053d7282 [File Tree] Significantly improve the watcher
- Switch to fine grained folder and file watching responses
- Navigate the PathNode tree using a fast dictionary of path components
- Quickly refresh the file tree by locating parent nodes to refresh

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2022-07-06 22:39:47 -07:00
Christopher Snowhill b4e3c05c87 [Playlist Loader] Load files in the background
Load new playlist entries in the background, asynchronously.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2022-07-06 14:28:14 -07:00
Christopher Snowhill 0832a8ea34 Restore the File Tree, now with a chooser button
Revert "Remove the file tree, as Sandbox does not permit"

This reverts commit 02ec735687.

This also changes how the File Tree choosing works.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2022-06-30 16:57:51 -07:00
Christopher Snowhill 02ec735687 Remove the file tree, as Sandbox does not permit
The Sandbox does not permit such controls to exist.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2022-06-29 11:56:01 -07:00
Christopher Snowhill 3ef6a4204f [Sandbox] Handle file tree path config better
Handle the configuration better, by adding the path to the grants list
if it is newly configured.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2022-06-29 00:31:34 -07:00
Christopher Snowhill f1dd55b29e [File Tree] Pop permission grant on setting root
Setting the root path should now pop up a permission grant dialog.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2022-06-27 16:17:54 -07:00
Christopher Snowhill 0e4ff8a55c [Sandbox] Compare to the actual user paths
Remove the sandbox reference, because the user will add folders outside
the sandbox, and we have entitlements to access these folders.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2022-06-26 02:59:49 -07:00
Christopher Snowhill ba33218ddf [Path Suggester] Automatically pop where required
The Path Suggester will now automatically open when new files are added
to the playlist and a given path is not in the sandbox settings. It will
also pop for both the File Tree and MIDI SoundFont path configuration
settings being changed.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2022-06-24 00:52:03 -07:00
Christopher Snowhill 2c2a058126 Cog now requires macOS 10.13 as a minimum version
All optional fallback code for older versions has also been removed, and
everything now assumes 10.13.0 or newer. Some cases are still included
for point releases, such as 10.13.2.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2022-06-23 23:23:07 -07:00
Christopher Snowhill a1ab3deec4 [File Tree] Implement Sandbox support
Implement Sandbox Broker support for the File Tree root path, in case it
is needed to enumerate files from within it.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2022-06-20 23:32:40 -07:00
Christopher Snowhill 8db2e41049 [Event Handling] Add context to all observers
Add context field to all observers that support it, in case it's useful.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2022-06-15 16:47:43 -07:00
Christopher Snowhill b03fdeaf7a [File Tree Browser] Fix resource leak
These two objects were or could have been leaked previously.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2022-06-11 13:40:08 -07:00
Christopher Snowhill 85c7073649 Reformat my own source code with clang-format
Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2022-02-06 21:49:27 -08:00
Christopher Snowhill 29ad6e3060 File Tree: Accidentally removed logging header that's used elsewhere 2022-01-23 15:02:46 -08:00
Christopher Snowhill 003b30cba2 File Tree: Remove useless logging, as the issue is apparently with pCloud's FUSE host 2022-01-23 14:43:22 -08:00
Christopher Snowhill 06adf472e9 File Tree: Bodge removed as it doesn't work, logging added for missing files 2022-01-23 13:22:52 -08:00
Christopher Snowhill 38e013e4ab File Tree: Attempt Unicode Normalization Form bodge on enumerated paths 2022-01-22 20:32:18 -08:00
Christopher Snowhill 684951bdc0 Change a bunch of NSArray declarations to const collection literals 2022-01-18 18:12:57 -08:00
Christopher Snowhill 217b3d4cf9 Attempt to clean up 10.13+ stuff with fallbacks to the old ways 2021-09-23 00:49:51 -07:00
Christopher Snowhill 13bd399b31 Clean up most warnings and update some dependencies 2021-04-29 18:16:24 -07:00
Dzmitry Neviadomski c1da9a66e1 Modernize several classes.
Use modern ObjC syntax.
Use new Pasteboard APIs.
Explicitly declare protocols.
2021-01-31 02:14:08 +03:00
Dzmitry Neviadomski a0afe85130 Fix deprecations with replacemnt and reindent touched files. 2021-01-27 05:30:19 +03:00
Jan Weiß 57ebc65ba0 Add missing newlines. 2020-02-01 14:00:41 +01:00
Christopher Snowhill 67495009ff Updates for new build system. 2018-06-28 04:03:37 -07:00
Chris Moeller 17272ce43c Clean up lots of warnings and minor issues. 2016-06-29 22:10:29 -07:00
Chris Moeller 03b825ced3 Hopefully fix the last of the Automatic Reference Counting issues that remained. 2016-06-19 12:57:18 -07:00
Chris Moeller 0e3644177e Updated everything else to ARC, and plugged a release cycle. 2016-05-05 13:05:39 -07:00
Chris Moeller 7120ba2dd9 Hopefully fixed the file tree crashing on startup if it was configured to an invalid path 2015-02-08 18:15:42 -08:00
Chris Moeller af76c33bb0 mamburu: Happy New Year commit (which accidentally fixes #83 - enqueueing from FileTree now respects playlist settings while FileTree context menu items still do what they say and don't depend on playlist settings). Also, the code should be cleaned up a bit, but i'm too sleepy to do it now. 2013-10-12 14:31:28 -07:00
Chris Moeller 35e8aa4db1 mamburu: 'Add to playlist' and 'Set to playlist' from the file tree context menu should now 'do what it says on the tin' (and not depend on playlist preferences setting) 2013-10-12 14:02:40 -07:00
Chris Moeller eab60596eb mamburu: Display track titles from cue in file tree 2013-10-11 05:45:08 -07:00
Chris Moeller e5a648578b mamburu: Logging improved, no more excessive logging in release builds 2013-10-11 05:03:55 -07:00
Chris Moeller 3f35b5e07f mamburu: Expandedness state of file drawer is now persisted over app restarts 2013-10-11 03:03:23 -07:00
Chris Moeller 3e057adf56 Replaced every instance of NSEnumerator with for/in loops 2013-10-10 01:44:45 -07:00
Chris Moeller 742f1388a6 Sort directory nodes above file nodes 2013-10-09 11:30:09 -07:00
Chris Moeller 203109ebc3 Sort paths by name 2013-10-09 11:29:59 -07:00
Chris Moeller ec0e45381e Cleaned up most of the warnings, eliminated use of deprecated APIs, and fixed the hotkeys crashing. 2013-10-03 01:00:58 -07:00
mscott 1269de06f9 Add artwork fetch from image file in directory when no embedded image is found (looks for image files named or ending with "cover", "folder", "album" or "front").
Clean up playlist popup menu validation.
2010-04-05 12:40:17 -05:00
vspader 288c5cbee5 Misc leaks fixes. 2009-09-01 21:14:07 -07:00
mscott 11352ab6de Enhancements to File Tree (contextual menu, sort order, etc.).
Added File Tree contextual menu (Add to Playlist, Show in Finder, etc.).
File Tree and additions to play list now use Finder sort order.
File Tree Root can be set via its popup menu or drag and drop from File Tree.
Alias names are now shown in File Tree (aliases are still resolved).
Added option to skip reading of cue sheets when adding a folder to play list.
2009-08-16 11:49:34 -05:00
vspader b79346e3b1 Fixed up file tree. 2009-03-07 13:31:44 -08:00
vurlix 38e6e9af62 fix some bugs reported by the clang static analyzer 2008-08-26 17:45:16 +00:00
vspader f06ff8d17d Enter now adds files from the file tree. 2008-06-21 05:25:38 +00:00
vspader f53bfc861d Side pane say what? 2008-06-21 04:05:30 +00:00