Commit Graph

36 Commits (1dffaae990398ede60d52bdb702e8c099ee9916f)

Author SHA1 Message Date
Christopher Snowhill a978dfbf5a MAD Decoder: Fix MP3 decoding crash
There was a stupid bug in the previous commit I made, which caused local
or seekable MP3 files to crash the player on decode. This fixes that, by
checking that a packet has actually been decoded before touching the
packet info structures. Dumb, dumb, dumb error on my part.

Fixes #244

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2022-02-26 04:26:12 -08:00
Christopher Snowhill ca3dec4497 MAD Decoder: Support changing format
Support the weird scenario of format changes mid-stream. Probably
highly unlikely, and likely to break things if it does occur, but
whatever, it might actually happen in some weird file.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2022-02-26 01:43:54 -08:00
Christopher Snowhill 53209485c0 MAD Decoder: Correctly prepare buffer after free
The current buffer size argument is used to determine if a buffer should
be allocated on the next run. Just in case something reuses the same
decoder instance.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2022-02-26 01:38:17 -08:00
Christopher Snowhill 2c0f04bbeb Possibly improve MAD sample conversion speed
No idea if this brings a noticeable improvement, but it probably makes
better sense to only do the division step one time instead of doing it
twice interleaved when processing stereo files, which are the most
common scenario anyway.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2022-02-26 01:08:55 -08:00
Christopher Snowhill 19556cc630 Brought back the MAD plugin from death
Now Cog supports freeformat MP3 once again. The plugin has been extended
to include sample accurate seeking, accurate length probing of files
missing headers, and iTunes gapless info reading using libid3tag.

Signed-off-by: Christopher Snowhill <kode54@gmail.com>
2022-02-24 17:51:10 -08:00
Chris Moeller 707bc85e24 Removed MAD plugin 2013-10-08 23:56:49 -07:00
Chris Moeller 74b6188772 Implemented floating point sample format support into CogAudio and all relevant plug-ins 2013-10-05 14:15:09 -07:00
Chris Moeller ec0e45381e Cleaned up most of the warnings, eliminated use of deprecated APIs, and fixed the hotkeys crashing. 2013-10-03 01:00:58 -07:00
vspader f1b965bf12 Patch from T. Million for 24-bit mad output. 2009-11-30 20:18:47 -08:00
vspader b78bae6e99 Small gapless fixes. 2009-02-27 21:25:54 -08:00
vspader 672c05ec14 Further tweaks to mp3 gapless logic. 2009-02-26 22:46:05 -08:00
vspader 94259fd366 Fix up gapless logic a little. 2009-02-26 22:12:05 -08:00
vspader 876efcde38 Rearranged comparison to prevent underflow. 2009-02-26 21:31:20 -08:00
vspader 549a0cf2da Fix for MAD sample scaling routine. 2008-05-03 19:37:10 +00:00
vspader a54f6ecfe5 Fixed bitrate calculation. 2008-02-20 01:09:15 +00:00
areff f20b10fdd4 Most of the Repeat logic is in place (needs some brush up here and there). Still missing Repeat Album. Disabled some annoying debug output from MADDecoder. Updated KnownIssues. 2008-02-19 19:59:35 +00:00
vspader 8434f6e3b3 Added RepeatTransformers with the beginnings of support for the repeat modes. MenuItems's reflect the repeat state (yet do not work to set the state yet), and the repeat button toggles w/images as expected.. 2008-02-19 03:39:43 +00:00
vspader 5434fe510b Fixed mp3 bitrate calculation. 2008-02-17 19:59:01 +00:00
vspader 5715522470 Moved to frame-based reading/seeking instead of byte/second based. Some formats have still not been updated and are broken.
Added icons for other formats.
2007-11-24 20:16:27 +00:00
vspader 97ff03f184 Preliminary gapless playback. 2007-10-18 02:33:12 +00:00
vspader 0e2dcf5014 Added m4a to taglib types. 2007-10-16 22:45:09 +00:00
vspader 4b814bdbf0 Added back update notifications back to the file drawer.
Removed no-longer-used files.
Removed debugging messages.
2007-10-15 03:29:30 +00:00
vspader 535e0e802f Updated mime-types. 2007-10-14 18:56:23 +00:00
vspader f1b9141f4b Added mime type support. 2007-10-14 18:12:15 +00:00
vspader d5919bc93e Further cleanup and memory leak fixes. 2007-10-13 07:51:42 +00:00
vspader 97a278a143 Cleaned up memory leaks. 2007-10-13 07:09:46 +00:00
vspader 139bab5e0e Fixed up streaming a bit.
Removed debugging code for http source. Was that in 0.06? Whoops.
2007-10-12 02:55:59 +00:00
vspader 50395e6e72 Basic cue sheet support working. Bug city. 2007-10-10 01:59:25 +00:00
vspader daba91b462 Removed debugging messages. 2007-07-11 01:20:32 +00:00
vspader 78a908274b Fixed bug where unseekable songs still allowed the user to move the slider and updated the time. 2007-05-27 15:11:30 +00:00
vspader 5f7215e5e7 Fixed overflow error. 2007-05-22 23:37:22 +00:00
vspader 4b3f31b51a Removed debugging message. 2007-03-04 00:33:41 +00:00
vspader 7d6c8fc6f5 MP3 streaming! 2007-03-04 00:17:05 +00:00
vspader 1aead1bf0d Merged decoder and converter threads to facilitate midstream format changing. 2007-03-03 17:19:37 +00:00
vspader eb5ee1586d Fixed up Vorbis Decoder and modified MAD to use new source system. 2007-03-03 00:33:36 +00:00
vspader 927b65a4a5 Merged with cog-audio-framework branch. Cog now uses plugins. 2007-02-24 20:36:27 +00:00