From 196f293a270cfb0caa18dafa79dafff7f8218080 Mon Sep 17 00:00:00 2001 From: Leah Rowe Date: Mon, 4 Sep 2023 21:23:18 +0100 Subject: [PATCH] build/release/roms: fix ucode handling microcode_required wasn't being reset per target, leading to unreliable results. this fixes that. Signed-off-by: Leah Rowe --- script/build/release/roms | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/script/build/release/roms b/script/build/release/roms index f9b7d2f2..10c0d6b2 100755 --- a/script/build/release/roms +++ b/script/build/release/roms @@ -92,9 +92,10 @@ make_archive() [ -f "config/coreboot/${target}/target.cfg" ] || \ err "make_archive: ${target}: target.cfg is missing" + microcode_required="y" . "config/coreboot/${target}/target.cfg" - [ "${microcode_required}" = "y" ] || \ - [ "${microcode_required}" = "n" ] || microcode_required="y" + if [ "${microcode_required}" != "y" ] && \ + [ "${microcode_required}" != "n" ]; then microcode_required="y"; fi for x in CONFIG_HAVE_MRC CONFIG_HAVE_ME_BIN CONFIG_KBC1126_FIRMWARE \ CONFIG_INCLUDE_SMSC_SCH5545_EC_FW; do